Skip to content

8303613: EdECPrivateKey should support Destroyable.destroy() #26074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

driverkt
Copy link
Member

@driverkt driverkt commented Jul 1, 2025

This PR is to fix the mentioned bug, but it should also establish a pattern for a larger refactor of similar classes. See also: #25632


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8303613: EdECPrivateKey should support Destroyable.destroy() (Enhancement - P4) ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26074/head:pull/26074
$ git checkout pull/26074

Update a local copy of the PR:
$ git checkout pull/26074
$ git pull https://git.openjdk.org/jdk.git pull/26074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26074

View PR using the GUI difftool:
$ git pr show -t 26074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26074.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2025

👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@driverkt driverkt marked this pull request as draft July 1, 2025 16:46
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 1, 2025
@openjdk
Copy link

openjdk bot commented Jul 1, 2025

@driverkt The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security [email protected] and removed rfr Pull request is ready for review labels Jul 1, 2025
@@ -127,7 +127,7 @@ private void readObject(ObjectInputStream stream)
}

@Override
public void destroy() throws DestroyFailedException {
public void destroy() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This method body might be refactored as part of another PR in a similar fashion, but for now, we just remove the explicit throws.

*/
@Override
public void destroy() {
super.destroy();
Copy link
Member Author

@driverkt driverkt Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is possible due to the cleaner registered in PKCS8Key and should zero out its fields before doing the subclass's destroy.

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 13, 2025
@driverkt driverkt closed this Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status security [email protected]
Development

Successfully merging this pull request may close these issues.

1 participant