-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8303613: EdECPrivateKey should support Destroyable.destroy() #26074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…for a larger refactor
👋 Welcome back kdriver! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@@ -127,7 +127,7 @@ private void readObject(ObjectInputStream stream) | |||
} | |||
|
|||
@Override | |||
public void destroy() throws DestroyFailedException { | |||
public void destroy() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method body might be refactored as part of another PR in a similar fashion, but for now, we just remove the explicit throws
.
*/ | ||
@Override | ||
public void destroy() { | ||
super.destroy(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is possible due to the cleaner registered in PKCS8Key and should zero out its fields before doing the subclass's destroy
.
This PR is to fix the mentioned bug, but it should also establish a pattern for a larger refactor of similar classes. See also: #25632
Progress
Error
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26074/head:pull/26074
$ git checkout pull/26074
Update a local copy of the PR:
$ git checkout pull/26074
$ git pull https://git.openjdk.org/jdk.git pull/26074/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26074
View PR using the GUI difftool:
$ git pr show -t 26074
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26074.diff