8359083: Test jdkCheckHtml.java should report SkippedException rather than report fails when miss tidy

[sendaoYan]

Hi all,

When there is no tidy command in PATH, the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java report failure, I think it shoule be report jtreg.SkippedException rather than report test failure.
In file test/docs/jdk/javadoc/doccheck/DocCheck.java, we need to call the new TidyChecker() before executing the test so that the jtreg.SkippedException exception can be thrown normally, that's why I add new TidyChecker() in init() function.

Change has been verified locally, only the test test/docs/jdk/javadoc/doccheck/checks/jdkCheckHtml.java observed this failure, test-fix only, no risk.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8359083: Test jdkCheckHtml.java should report SkippedException rather than report fails when miss tidy (Bug - P4)

Reviewers

• Hannes Wallnöfer (@hns - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25711/head:pull/25711
$ git checkout pull/25711

Update a local copy of the PR:
$ git checkout pull/25711
$ git pull https://git.openjdk.org/jdk.git pull/25711/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25711

View PR using the GUI difftool:
$ git pr show -t 25711

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25711.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359083: Test jdkCheckHtml.java should report SkippedException rather than report fails when miss tidy

Reviewed-by: hannesw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• bf7d40d: 8356751: IGV: clean up redundant field _should_send_method
• 5ae32c4: 8352149: Test java/awt/Frame/MultiScreenTest.java fails: Window list is empty
• 56ce70c: 8359165: AIX build broken after 8358799
• ... and 9 more: https://git.openjdk.org/jdk/compare/ca7b885873712a5ae503cb82c915d709034a69f7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[sendaoYan]

/label add doc

[openjdk]

@sendaoYan
The label doc is not a valid label.
These labels are valid:

• graal
• serviceability
• hotspot
• hotspot-compiler
• ide-support
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• security
• hotspot-runtime
• jmx
• build
• nio
• client
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr

[sendaoYan]

/label add javadoc

[openjdk]

@sendaoYan
The javadoc label was successfully added.

[mlbridge]

Webrevs

• 00: Full (b8e66901)

[hns]

Changes look good to me.

[sendaoYan]

Thanks @hns for the review.

/integrate

[openjdk]

Going to push as commit 3e0ef83.
Since your change was applied there have been 24 commits pushed to the master branch:

• 7b7136b: 8359181: Error messages generated by configure --help after 8301197
• 5886ef7: 8359182: Use @requires instead of SkippedException for MaxPath.java
• d7aa349: 8357826: Avoid running some jtreg tests when asan is configured
• ... and 21 more: https://git.openjdk.org/jdk/compare/ca7b885873712a5ae503cb82c915d709034a69f7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 3e0ef83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.