8358815: Exception event spec has stale reference to catch_klass parameter

[sspitsyn]

The JVMTI Exception event callback spec refers to the catch_klass parameter which does not exist anymore. Instead the Exception event callback spec should refer to the catch_method and catch_location parameters.
I treat this as a bug and doubt we need a CSR for this issue.

Testing: N/A

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358815: Exception event spec has stale reference to catch_klass parameter (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25710/head:pull/25710
$ git checkout pull/25710

Update a local copy of the PR:
$ git checkout pull/25710
$ git pull https://git.openjdk.org/jdk.git pull/25710/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25710

View PR using the GUI difftool:
$ git pr show -t 25710

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25710.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358815: Exception event spec has stale reference to catch_klass parameter

Reviewed-by: cjplummer, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 38 new commits pushed to the master branch:

• 4291582: 8357382: runtime/cds/appcds/aotClassLinking/BulkLoaderTest.java#aot fails with Xcomp and C1
• ef4cbec: 8358556: Assert when running with -XX:-UseLibmIntrinsic
• e9216ef: 8358734: Remove JavaTimeSupplementary resource bundles
• ... and 35 more: https://git.openjdk.org/jdk/compare/d024f58e61ec27f6c13fde5dadb95c31875815d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sspitsyn The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (ad760f49)
• 01: Full - Incremental (021756c5)
• 00: Full (ba775955)

[AlanBateman]

catch_method is a jmethodID so null if uncaught.

[plummercj]

Then you also need to fix:

"If there is no such catch clause, each field is set to 0."

Also, technically speaking, can't catch_location be 0 even if caught (caught first the bytecode of the method)? Although I doubt javac would ever generate such code, it seems it is allowed. If so, then catch_method == null is the only check a user should make.

[sspitsyn]

Thank you for the comments!
Yes, I've also come to the same conclusion about the only catch_method == null check.

Then you also need to fix:
"If there is no such catch clause, each field is set to 0."

Good catch, thanks.

The suggestions above have addressed now.
Also, I've replaced the term field with parameter for consistency in two spots.

[AlanBateman]

I think what you have looks okay now. I'm just wondering about the description for the catch_location parameter has "zero if no known catch". So if catch_method is null then catch_location must be 0.

[sspitsyn]

Thank you, Alan. I've updated the event description.

[plummercj]

Looks good.

[sspitsyn]

Alan and Chris, thank you for review!

[sspitsyn]

/integrate

[openjdk]

Going to push as commit 8f73357.
Since your change was applied there have been 38 commits pushed to the master branch:

• 4291582: 8357382: runtime/cds/appcds/aotClassLinking/BulkLoaderTest.java#aot fails with Xcomp and C1
• ef4cbec: 8358556: Assert when running with -XX:-UseLibmIntrinsic
• e9216ef: 8358734: Remove JavaTimeSupplementary resource bundles
• ... and 35 more: https://git.openjdk.org/jdk/compare/d024f58e61ec27f6c13fde5dadb95c31875815d6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sspitsyn Pushed as commit 8f73357.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.