Skip to content

8352292: Implement NMT tags using hashtables #25701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gerard-ziemski
Copy link

@gerard-ziemski gerard-ziemski commented Jun 9, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Errors

 ⚠️ OCA signatory status must be verified
 ⚠️ The pull request body must not be empty.

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8352292

Warnings

 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletColor32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono16.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/beaninfo/images/JAppletMono32.gif)
 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/doc-files/JRootPane-1.gif)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/keystore)
 ⚠️ Patch contains a binary file (test/jdk/javax/rmi/ssl/truststore)
 ⚠️ Patch contains a binary file (test/jdk/jdk/internal/loader/URLClassPath/testclasses.jar)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/dnsstore)
 ⚠️ Patch contains a binary file (test/jdk/sun/net/www/protocol/https/HttpsClient/ipstore)

Issue

  • JDK-8352292: NMT experiment: implement NMT tags using hashtables (Enhancement - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25701/head:pull/25701
$ git checkout pull/25701

Update a local copy of the PR:
$ git checkout pull/25701
$ git pull https://git.openjdk.org/jdk.git pull/25701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25701

View PR using the GUI difftool:
$ git pr show -t 25701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25701.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 9, 2025

👋 Welcome back gziemski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Jun 9, 2025

@gerard-ziemski The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk
Copy link

openjdk bot commented Jul 14, 2025

@gerard-ziemski this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8352292
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jul 14, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2025

@gerard-ziemski This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime [email protected] merge-conflict Pull request has merge conflict with target branch oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant