8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null

[kevinjwalls]

Simple correction where API docs state a return value may be "null", but in fact this is a result of type long, and may be zero.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8359040 to be approved

Issues

• JDK-8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null (Bug - P4)
• JDK-8359040: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null (CSR)

Reviewers

• Serguei Spitsyn (@sspitsyn - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25694/head:pull/25694
$ git checkout pull/25694

Update a local copy of the PR:
$ git checkout pull/25694
$ git pull https://git.openjdk.org/jdk.git pull/25694/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25694

View PR using the GUI difftool:
$ git pr show -t 25694

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25694.diff

Using Webrev

Link to Webrev Comment

[kevinjwalls]

/csr

[bridgekeeper]

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null

Reviewed-by: sspitsyn, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 75 new commits pushed to the master branch:

• 9982995: 8358819: The first year is not displayed correctly in Japanese Calendar
• 0ef0986: 8359168: Revert stdin.encoding usage in test/hotspot/jtreg/vmTestbase/nsk/jvmti/AttachOnDemand/attach010/attach010Agent00.java
• 610a18e: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher
• ... and 72 more: https://git.openjdk.org/jdk/compare/af87035b713f8bfe05a007a4d4670cefc6a6aaf2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@kevinjwalls has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinjwalls please create a CSR request for issue JDK-8358970 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[openjdk]

@kevinjwalls The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e032a726)

[sspitsyn]

Looks good and trivial.

[kevinjwalls]

Thanks for the reviews!

[kevinjwalls]

/integrate

[openjdk]

Going to push as commit 523a4ef.
Since your change was applied there have been 78 commits pushed to the master branch:

• 0dd7c69: 8357286: (bf) Remove obsolete instanceof checks in CharBuffer.append
• 66535fe: 8358701: Remove misleading javax.management.remote API doc wording about JMX spec, and historic link to JMXMP
• db7af2b: 8349550: Improve SASL random usage
• ... and 75 more: https://git.openjdk.org/jdk/compare/af87035b713f8bfe05a007a4d4670cefc6a6aaf2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinjwalls Pushed as commit 523a4ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.