8358958: (aio) AsynchronousByteChannel.read/write should throw IAE if buffer is thread-confined

[AlanBateman]

It's nonsensical to invoke read/write methods defined by the AsynchronousXXX channels with buffers that are views of memory segments allocated from a thread-confined arena.

For AsynchronousSocketChannel, the current behavior is for the read/write methods to initiate an I/O operation that completes with an IOException and an IllegalStateException as cause. For AsynchronousFileChannel, the current behavior is for the read/write methods to initiate an I/O operation that never completes (a thread in the channel groups terminates with a WrongThreadException).

The proposal is that the read/write methods reject, with IllegalArgumentException, any attempt to initiate as async I/O operation with a buffer from a thread-confined arena. IAE is already declared to be thrown for read-only buffers or attempting a positional read/write with a negative file position.

The java/nio/channels/etc/MemorySegments.java test is updated to test AsynchronousSocketChannel and AsynchronousFileChannel with buffers from all arena kinds. The tests include attempts to close a shared arena while an I/O operation is in progress. For now, the testAsyncFileChannelXXX tests are disabled until they meet up with the changes in JDK-8357847 (pr/25531).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8359125 to be approved

Issues

• JDK-8358958: (aio) AsynchronousByteChannel.read/write should throw IAE if buffer is thread-confined (Bug - P4)
• JDK-8359125: (aio) AsynchronousByteChannel.read/write should throw IAE if buffer is thread-confined (CSR)

Reviewers

• Brian Burkhalter (@bplb - Reviewer) Review applies to 4a66c604
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25691/head:pull/25691
$ git checkout pull/25691

Update a local copy of the PR:
$ git checkout pull/25691
$ git pull https://git.openjdk.org/jdk.git pull/25691/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25691

View PR using the GUI difftool:
$ git pr show -t 25691

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25691.diff

Using Webrev

Link to Webrev Comment

[AlanBateman]

/csr

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358958: (aio) AsynchronousByteChannel.read/write should throw IAE if buffer is thread-confined

Reviewed-by: jpai, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

• 523a4ef: 8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null
• 0dd7c69: 8357286: (bf) Remove obsolete instanceof checks in CharBuffer.append
• 66535fe: 8358701: Remove misleading javax.management.remote API doc wording about JMX spec, and historic link to JMXMP
• ... and 20 more: https://git.openjdk.org/jdk/compare/3b32f6a8ec37338764d3e6713247ff96e49bf5b3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@AlanBateman this pull request must refer to an issue in JBS to be able to link it to a CSR request. To refer this pull request to an issue in JBS, please update the title of this pull request to just the issue ID.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (60658f18)
• 01: Full - Incremental (4a66c604)
• 00: Full (d7734f91)

[bplb]

Implementation changes look fine.

[bplb]

Looks fine to me.

[jaikiran]

The changes look OK to me. I glanced through the tests (especially the MemorySegments.java) and they look fine too.

[jaikiran]

AsynchronousFileChannelImpl.java requires a copyright year update.

[jaikiran]

This looks good to me.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit 9aeacf2.
Since your change was applied there have been 24 commits pushed to the master branch:

• 991097b: 8315066: Add unsigned bounds and known bits to TypeInt/Long
• 523a4ef: 8358970: CounterMonitorMBean.getDerivedGaugeTimeStamp() JavaDoc incorrectly documents null
• 0dd7c69: 8357286: (bf) Remove obsolete instanceof checks in CharBuffer.append
• ... and 21 more: https://git.openjdk.org/jdk/compare/3b32f6a8ec37338764d3e6713247ff96e49bf5b3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit 9aeacf2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.