Skip to content

8349347: Very long-running regex with Matcher.find #25499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

igraves
Copy link
Member

@igraves igraves commented May 28, 2025

Updates to the Regex engine Curly and GroupCurly quantifier constructs so they do not match more than once against an empty slice or an empty group.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8349347: Very long-running regex with Matcher.find (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25499/head:pull/25499
$ git checkout pull/25499

Update a local copy of the PR:
$ git checkout pull/25499
$ git pull https://git.openjdk.org/jdk.git pull/25499/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25499

View PR using the GUI difftool:
$ git pr show -t 25499

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25499.diff

@igraves igraves marked this pull request as draft May 28, 2025 16:19
@bridgekeeper
Copy link

bridgekeeper bot commented May 28, 2025

👋 Welcome back igraves! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 28, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented May 28, 2025

@igraves The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2025

@igraves This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] oca Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

1 participant