Remember/reuse last value improvements #6648
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 31adbe9: arm64-android |
nirvn
changed the title
mohsenD98
reviewed
Sep 17, 2025
Comment on lines
+934
to
+935
| width: 49 | ||
| height: 48 |
Comment on lines
+352
to
+369
| void AttributeFormModelBase::activateAllRememberValues() | ||
| { | ||
| QMap<QStandardItem *, int>::ConstIterator fieldIterator( mFields.constBegin() ); | ||
| for ( ; fieldIterator != mFields.constEnd(); ++fieldIterator ) | ||
| { | ||
| setData( fieldIterator.key()->index(), true, AttributeFormModel::RememberValue ); | ||
| } | ||
| } | ||
|
|
||
| void AttributeFormModelBase::deactivateAllRememberValues() | ||
| { | ||
| QMap<QStandardItem *, int>::ConstIterator fieldIterator( mFields.constBegin() ); | ||
| for ( ; fieldIterator != mFields.constEnd(); ++fieldIterator ) | ||
| { | ||
| setData( fieldIterator.key()->index(), false, AttributeFormModel::RememberValue ); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
The implementation of activateAllRememberValues and deactivateAllRememberValues is clear and consistent with the codebase;
However, currently, these functions apply to all fields, regardless of whether CanRememberValue is true.
for added robustness, you might check CanRememberValue before setting RememberValue, otherwise everything looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a menu in the feature addition form that allows for users to quickly activate / deactivate the pin tool button that dictates whether a given attribute value will be remembered and reused during the next feature addition.
Screenshot:
In addition, logic can be added into QField now, in preparation for QGIS 4.0, where the reusing of value functionality has been improved, with distinct options to activate/deactivate the possibility to reuse values and whether they should be remembered by default. The only thing left to do after this will be a vcpkg rebase when we get closer to QGIS 4.0 release date (or a manual patch if needed).
A bit more on this: it will answer the repeated asks by the community to get a way to get rid of the "remember last value" button in the feature addition form. That's quite exciting to me :)