Cast websiteId to int before passing it to loadBySubscriberEmail #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare release
Second variable should always be int for loadBySubscriberEmail. However, sometimes Store->getWebsiteId() returns string or null Therefore we must cast it to int before passing it along.
Member
|
Thank you @Quazz for your contribution, it's very appreciated 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Newsletter/Model/Subscriber.php#L391 it expects int for its second argument.
However, https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Store/Model/Store.php#L1060 Store->getWebsiteId() can return string|int|null
Therefore we must cast the websiteId manually to int in order to avoid a type error such as this:
Cron Job gdpr_erase_entity has an error: Argument 2 passed to Magento\Newsletter\Model\Subscriber::loadBySubscriberEmail() must be of the type int, string given, called in magento2/vendor/opengento/module-gdpr/Model/Order/Delete/Processor/SubscriberDataProcessor.php on line 64