feat: add get_url method and product_update_url property #391 #410
+26
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to In progress
in 🐍 Python SDK - Keep on par with the API
|
| # See | ||
| # https://github.com/openfoodfacts/openfoodfacts-server/issues/1607 | ||
| url += "?fields={}".format(",".join(fields)) | ||
| url = self.get_url(code, fields) |
Member
There was a problem hiding this comment.
you don’t need a separate function. can the logic go directly inside the existing get() method? 🤔
Author
There was a problem hiding this comment.
The URL construction was extracted into get_url() so it can be reused and inspected independently of get().
This allows users to log or debug the exact endpoint without triggering a request, which aligns with the original goal of exposing the URL.
If you prefer keeping the logic inline for simplicity, I can move it back into get().
@areebahmeddd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added get_url method to ProductResource and exposed product_update_url.
Solution
The goal of this PR is to allow users to inspect the API URLs without actually triggering a network request. Here’s how I handled it:
Extracted URL Logic: I created a new get_url method. Previously, the URL construction was hardcoded inside the get method. Now, it lives in its own reusable function.
Refactored get method: I updated the existing get method to call get_url internally. This removes code duplication and keeps the logic consistent.
Exposed Update URL: I added a product_update_url property. This gives users a direct way to see the endpoint used for product updates (/cgi/product_jqm2.pl).
Improved Flexibility: Users can now pass a list of fields to get_url to see exactly what the final query string will look like before fetching data.
Related issue(s)