Add SearchParams helper with validation and tests #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to In progress
in 🐍 Python SDK - Keep on par with the API
|
Author
|
Linking the discussion for visibility. Refs #314. Happy to adjust naming or placement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a small typed SearchParams helper for building query dicts. This helps users compose richer searches while discussion on the full Search a licious client continues.
What is included
SearchParams with light validation and to_query
Unit tests for valid and invalid inputs plus a simple pagination case
No network calls in unit tests
Why this fits
Keeps the surface area small and backward compatible. Gives a safe building block for later work on the new search endpoint.
Testing
Ran pytest locally for the new tests. The ML tests are excluded to keep the run fast and deterministic. CI should run the standard matrix.
AI note
I drafted parts of this with AI help and reviewed and tested all code myself per the project policy.
Refs #314