Skip to content

[codex] optimize mesh submesh validation for static scenes #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kitwongpixel wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[codex] optimize mesh submesh validation for static scenes #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions away3d/entities/Mesh.hx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import away3d.core.partition.*;
import away3d.events.*;
import away3d.library.assets.*;
import away3d.materials.*;
import away3d.primitives.PrimitiveBase;

import openfl.Vector;

Expand Down Expand Up @@ -187,10 +188,11 @@ class Mesh extends Entity implements IMaterialOwner implements IAsset
*/
private function get_subMeshes():Vector<SubMesh>
{
// Since this getter is invoked every iteration of the render loop, and
// the geometry construct could affect the sub-meshes, the geometry is
// validated here to give it a chance to rebuild.
_geometry.validate();
// This getter runs every frame, so avoid paying a validation cost unless
// the geometry type can actually rebuild itself on demand. In practice
// that is limited to PrimitiveBase-derived geometries.
if (#if (haxe_ver >= 4.2) Std.isOfType #else Std.is #end(_geometry, PrimitiveBase))
_geometry.validate();

return _subMeshes;
}
Expand Down Expand Up @@ -381,4 +383,4 @@ class Mesh extends Entity implements IMaterialOwner implements IAsset

return _pickingCollisionVO.renderable != null;
}
}
}