-
Notifications
You must be signed in to change notification settings - Fork 3
build: sync package versions to match Authoring MFE for Teak #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: sync package versions to match Authoring MFE for Teak #51
Conversation
Thanks for the pull request, @tecoholic! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #51 +/- ##
===========================================
+ Coverage 16.61% 48.50% +31.88%
===========================================
Files 15 15
Lines 331 334 +3
Branches 65 60 -5
===========================================
+ Hits 55 162 +107
+ Misses 265 171 -94
+ Partials 11 1 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thanks for taking this on, it's been on my list to look into these failures for a while. One thing that we have talked about previously was also ignoring |
@bmtcril I agree about skipping the |
ddfe4b2
to
3fc3050
Compare
@bmtcril Sine the "peerDependenciesMeta" defines @farhaanbukhsh I tested this branch to install in frontend-app-authoring without And you can see that the CI are passing successfully now. If we can
We should be able to close openedx/tutor-contrib-aspects#1091. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
- ✅ I tested this by installing it without peer-dependency and making sure it's working
- ✅ I read through the code
- ❌ I checked for accessibility issues
- ❌ Includes documentation
Description
A few things about the current state of this plugin has been bothering me:
tutor-contrib-aspects
installs this plugin direct from Github with the--legacy-peer-deps
flag. So, it will always install themain
branch without any release/version pinning.So, I am creating this MR to see if we can do some housekeeping tasks by resolving the inconsistencies between this repo and the
frontend-app-authoring
and make the situation better.Here are the goals I hope to achieve:
npm install
can be straightforward without the--legacy-peer-deps
in a cleaner way.Important Changes
@edx/eslint-
packages to reduce dependency resolution failures.frontend-platform
,frontend-build
..etc., to that of Authoring MFE.