-
Notifications
You must be signed in to change notification settings - Fork 54
feat: Ora mobile responsive #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vladislavkeblysh
wants to merge
10
commits into
openedx:master
Choose a base branch
from
raccoongang:keblysh/feat/mobile-responsive
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
e5e4519
feat: [feat: ora mobile responsive]
vladislavkeblysh 52f657e
feat: ora mobile responsive
vladislavkeblysh c400cbb
Merge branch 'master' into keblysh/feat/mobile-responsive
vladislavkeblysh ad316c1
feat: ora mobile responsive
vladislavkeblysh bca389a
Merge remote-tracking branch 'rg/keblysh/feat/mobile-responsive' into…
vladislavkeblysh f3abfa8
Merge branch 'master' into keblysh/feat/mobile-responsive
vladislavkeblysh 64ff9c1
Merge branch 'master' into keblysh/feat/mobile-responsive
vladislavkeblysh df65af4
feat: refactor after review
vladislavkeblysh 2cad2c8
feat: refactor after review
vladislavkeblysh c368b65
Merge branch 'master' into keblysh/feat/mobile-responsive
vladislavkeblysh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
71 changes: 3 additions & 68 deletions
71
src/containers/ReviewModal/__snapshots__/index.test.jsx.snap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,72 +1,7 @@ | ||
// Jest Snapshot v1, https://goo.gl/fbAQLP | ||
|
||
exports[`ReviewModal component component snapshots closed 1`] = ` | ||
<FullscreenModal | ||
beforeBodyNode={ | ||
<React.Fragment> | ||
<ReviewActions /> | ||
<DemoWarning /> | ||
</React.Fragment> | ||
} | ||
className="review-modal" | ||
isOpen={false} | ||
modalBodyClassName="review-modal-body" | ||
onClose={[MockFunction hooks.onClose]} | ||
title="test-ora-name" | ||
> | ||
<CloseReviewConfirmModal | ||
prop="hooks.closeConfirmModalProps" | ||
/> | ||
</FullscreenModal> | ||
`; | ||
exports[`ReviewModal component component snapshots closed 1`] = `undefined`; | ||
|
||
exports[`ReviewModal component component snapshots loading 1`] = ` | ||
<FullscreenModal | ||
beforeBodyNode={ | ||
<React.Fragment> | ||
<ReviewActions /> | ||
<DemoWarning /> | ||
</React.Fragment> | ||
} | ||
className="review-modal" | ||
isOpen={true} | ||
modalBodyClassName="review-modal-body" | ||
onClose={[MockFunction hooks.onClose]} | ||
title="test-ora-name" | ||
> | ||
<ReviewContent /> | ||
<LoadingMessage | ||
message={ | ||
{ | ||
"defaultMessage": "Loading response", | ||
"description": "loading text for submission response review screen", | ||
"id": "ora-grading.ReviewModal.loadingResponse", | ||
} | ||
} | ||
/> | ||
<CloseReviewConfirmModal | ||
prop="hooks.closeConfirmModalProps" | ||
/> | ||
</FullscreenModal> | ||
`; | ||
exports[`ReviewModal component component snapshots loading 1`] = `undefined`; | ||
|
||
exports[`ReviewModal component component snapshots success 1`] = ` | ||
<FullscreenModal | ||
beforeBodyNode={ | ||
<React.Fragment> | ||
<ReviewActions /> | ||
<DemoWarning /> | ||
</React.Fragment> | ||
} | ||
className="review-modal" | ||
isOpen={true} | ||
modalBodyClassName="review-modal-body" | ||
onClose={[MockFunction hooks.onClose]} | ||
title="test-ora-name" | ||
> | ||
<ReviewContent /> | ||
<CloseReviewConfirmModal | ||
prop="hooks.closeConfirmModalProps" | ||
/> | ||
</FullscreenModal> | ||
`; | ||
exports[`ReviewModal component component snapshots success 1`] = `undefined`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably provide this via frontend-platform, but while we don't, the standard seems to be what authoring is doing (max 768px):
https://github.com/openedx/frontend-app-authoring/blob/master/src/utils.js#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed