Skip to content

Ulmo backport: prevent generatePath error when author is invalid in AuthorLabel #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2025
Merged

Ulmo backport: prevent generatePath error when author is invalid in AuthorLabel #830

merged 2 commits into from
Nov 14, 2025

Conversation

@blarghmatey
Copy link
Contributor

@blarghmatey blarghmatey commented Nov 14, 2025

Description

This is a backport PR of #821 for the Ulmo release.

How Has This Been Tested?

This has been deployed to the MIT operated production environment on the master branch and verified as resolving #817

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Sandbox, if applicable.
  • Is there adequate test coverage for your changes?

Post-merge Checklist

  • Deploy the changes to prod after verifying on stage or ask @openedx/edx-infinity to do it.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

renovate bot and others added 2 commits November 13, 2025 14:36
@renovate
chore(deps): update dependency @edx/frontend-platform to v8.5.2 (open…
16c49b2 
…edx#775)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@blarghmatey
fix: prevent generatePath error when author is invalid in AuthorLabel
ea85320 
Wrap learnerPostsLink creation in useMemo with guard to prevent
'Missing :learnerUsername param' error. The generatePath function
was being called unconditionally during render even when the link
wouldn't be displayed, causing errors when author was null, undefined,
or the 'anonymous' string.

The fix ensures generatePath is only called when showUserNameAsLink
is true, which validates that author is a valid username.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 14, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 14, 2025

Thanks for the pull request, @blarghmatey!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 14, 2025
@blarghmatey blarghmatey changed the title Tmacey/fix learner posts link Ulmo backport: prevent generatePath error when author is invalid in AuthorLabel Nov 14, 2025
@blarghmatey blarghmatey mentioned this pull request Nov 14, 2025
Merged
@sarina sarina added the release blocker Blocks the upcoming release (fix needed) label Nov 14, 2025
@sarina
Copy link
Contributor

sarina commented Nov 14, 2025

@farhaanbukhsh fyi

@brian-smith-tcril brian-smith-tcril merged commit 1268442 into openedx:release/ulmo Nov 14, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brian-smith-tcril brian-smith-tcril brian-smith-tcril approved these changes

Assignees

No one assigned

Labels

open-source-contribution PR author is not from Axim or 2U release blocker Blocks the upcoming release (fix needed)

Projects

Build-Test-Release Working Group
Status: Done
Contributions
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blarghmatey @openedx-webhooks @sarina @brian-smith-tcril