-
Notifications
You must be signed in to change notification settings - Fork 133
test: replacing snapshot tests with rtl tests part 14 #2236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
test: replacing snapshot tests with rtl tests part 14 #2236
Conversation
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
db1f685
to
33d6338
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2236 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 1165 1165
Lines 24646 24646
Branches 5374 5371 -3
=======================================
Hits 23207 23207
Misses 1362 1362
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
33d6338
to
ac04bbd
Compare
Description
This pr is replacing shallow and snapshot tests with rtl tools in order to deprecate @edx/react-unit-test-utils package.
Closes #2124
UT modified on this pr:
The snapshots related to these tests were removed.
The tests were turned into typescript tests files.