-
Notifications
You must be signed in to change notification settings - Fork 132
feat: add ParentBreadcrumbs component [FC-0090] #2223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: add ParentBreadcrumbs component [FC-0090] #2223
Conversation
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
951fa3e
to
7d229f6
Compare
d280706
to
46983d3
Compare
46983d3
to
b0647f8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2223 +/- ##
==========================================
- Coverage 94.14% 94.14% -0.01%
==========================================
Files 1164 1166 +2
Lines 24596 24618 +22
Branches 5249 5370 +121
==========================================
+ Hits 23157 23177 +20
+ Misses 1371 1364 -7
- Partials 68 77 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR adds the
ParentBreadcrumbs
component to show a list of parent containers on the Unit and Subsection breadcrumbs.Supporting information
Testing instructions
Open a unit not associated with any subsections
Check that the breadcrumbs show only the library name
Add a unit to one subsection
Open the Unit page and check that the breadcrumbs show a direct link to this subsection
Add the same unit to another subsection
Open the Unit page and check that the breadcrumbs show a menu listing both subsections
Repeat the process, checking Subsections associated with Sections
Private ref: FAL-4216