Skip to content

feat: remove unit/subsection from subsection/section #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 27, 2025

Conversation

DanielVZ96
Copy link
Contributor

@DanielVZ96 DanielVZ96 commented Jun 15, 2025

Description

Lets the user remove a unit/subsection from a subsection/section.

Supporting information

Issue: #1973 (comment) and #1985
Private-Ref

Testing instructions

  • In a library, create a section
  • Create a subsection inside that section
  • Create a unit inside that subsection
  • Go back to the subsection and remove the unit by clicking inside this menu
image
  • Make sure this pop up appears:
image
  • Then repeat the same steps to remove the subsection from the section.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 15, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 15, 2025

Thanks for the pull request, @DanielVZ96!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jun 15, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Jun 20, 2025
@DanielVZ96 DanielVZ96 force-pushed the dvz/section-subsection-remove branch from 25f0211 to e2f9ceb Compare June 21, 2025 15:39
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 96.55172% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.15%. Comparing base (aeefcc6) to head (df1b866).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../library-authoring/containers/ContainerRemover.tsx 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   94.15%   94.15%   -0.01%     
==========================================
  Files        1164     1165       +1     
  Lines       24599    24646      +47     
  Branches     5381     5371      -10     
==========================================
+ Hits        23162    23206      +44     
- Misses       1360     1363       +3     
  Partials       77       77              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DanielVZ96 DanielVZ96 marked this pull request as ready for review June 21, 2025 16:32
@DanielVZ96 DanielVZ96 force-pushed the dvz/section-subsection-remove branch from 1665a8a to 9da4333 Compare June 21, 2025 16:37
@DanielVZ96 DanielVZ96 requested a review from pomegranited June 21, 2025 16:46
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is working well, thank you @DanielVZ96 !

However, the backend isn't working so well -- when I remove a Subsection from a Section, and the re-open the removed Subsection, it still thinks its a member of the parent Section.

Will discuss more on the Jira ticket.

  • I tested this on my devstack using the PR test instructions.
  • I read through the code
  • I checked for accessibility issues by using my keyboard to navigate
  • Includes documentation
  • User-facing strings are extracted for translation

Copy link
Contributor

@ChrisChV ChrisChV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Fix the imports nit and fix de clonflicts to merge it

@ChrisChV ChrisChV merged commit e2da13d into openedx:master Jun 27, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants