-
Notifications
You must be signed in to change notification settings - Fork 146
feat: remove unit/subsection from subsection/section #2149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove unit/subsection from subsection/section #2149
Conversation
Thanks for the pull request, @DanielVZ96! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
25f0211
to
e2f9ceb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
- Coverage 94.15% 94.15% -0.01%
==========================================
Files 1164 1165 +1
Lines 24599 24646 +47
Branches 5381 5371 -10
==========================================
+ Hits 23162 23206 +44
- Misses 1360 1363 +3
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1665a8a
to
9da4333
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This is working well, thank you @DanielVZ96 !
However, the backend isn't working so well -- when I remove a Subsection from a Section, and the re-open the removed Subsection, it still thinks its a member of the parent Section.
Will discuss more on the Jira ticket.
- I tested this on my devstack using the PR test instructions.
- I read through the code
- I checked for accessibility issues by using my keyboard to navigate
- Includes documentation
- User-facing strings are extracted for translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Fix the imports nit and fix de clonflicts to merge it
Description
Lets the user remove a unit/subsection from a subsection/section.
Supporting information
Issue: #1973 (comment) and #1985
Private-Ref
Testing instructions
Other information
Include anything else that will help reviewers and consumers understand the change.