Skip to content

fix: pointer-events issue on toast container #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bydawen
Copy link
Contributor

@bydawen bydawen commented Jun 12, 2025

Fix issue with the pointer-events property on the toast container in the edit tags section:
#1898

For now it's have been problem that on the toast-container applies data-focus-on-hidden="true" attribute, that prevent click on the close toast button, it can be fixed via styles:
Screenshot 2025-06-12 at 17 15 41

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 12, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Jun 12, 2025

Thanks for the pull request, @bydawen!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jun 12, 2025
@bydawen bydawen marked this pull request as draft June 12, 2025 14:19
@bradenmacdonald
Copy link
Contributor

Could you please open a paragon issue or submit a PR to fix this in Paragon too? I'm assuming it's really a paragon problem.

Copy link

codecov bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.05%. Comparing base (c1d874f) to head (ee28bfb).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2139      +/-   ##
==========================================
+ Coverage   94.04%   94.05%   +0.01%     
==========================================
  Files        1163     1163              
  Lines       24434    24428       -6     
  Branches     5186     5185       -1     
==========================================
- Hits        22979    22976       -3     
+ Misses       1387     1384       -3     
  Partials       68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bydawen
Copy link
Contributor Author

bydawen commented Jun 15, 2025

Could you please open a paragon issue or submit a PR to fix this in Paragon too? I'm assuming it's really a paragon problem.

Done openedx/paragon#3654

@bydawen bydawen marked this pull request as ready for review June 19, 2025 07:52
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jun 20, 2025
@mphilbrick211 mphilbrick211 moved this from In Eng Review to Ready for Review in Contributions Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

3 participants