-
Notifications
You must be signed in to change notification settings - Fork 133
feat: add asset existence check before replacing static URLs #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @bra-i-am! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1708 +/- ##
==========================================
+ Coverage 94.03% 94.08% +0.05%
==========================================
Files 1163 1165 +2
Lines 24429 24470 +41
Branches 5316 5302 -14
==========================================
+ Hits 22972 23023 +51
+ Misses 1380 1370 -10
Partials 77 77 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3fb1f86
to
0123b77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a reasonable approach to fix #1265. Thank you! I would like for it to use react-query, though, if at all possible.
…CE content * fix: update image replacement in the initial value so the change is not taken as a user action
0123b77
to
a630e93
Compare
…ns and integrating new API hooks
@arbrandes, I have already addressed your comment and modified the code to implement the fix using react-query. I'm looking forward to your feedback! Thanks ✨ |
Thanks, @bra-i-am! I'm putting this back on my queue. I'll try to get to it before the conference, but it's possible I'll only be able to review or on after July 7th. |
@bra-i-am: can you help us fix the branch conflicts? Thanks! |
Description
This merge request solves an issue where the save warning is shown without making changes to new courses. Additionally, it also adds an existence check before replacing the static URLs
Supporting information
#1265
Testing instructions
contentstore.new_studio_mfe.use_new_schedule_details_page
Course overview
it must be displayed the default images if the assets are not found