-
Notifications
You must be signed in to change notification settings - Fork 34
feat: Enable status filter and sorting in Approved Requests table #1643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Enable status filter and sorting in Approved Requests table #1643
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1643 +/- ##
==========================================
- Coverage 86.87% 86.79% -0.08%
==========================================
Files 796 796
Lines 18106 18135 +29
Branches 3795 3806 +11
==========================================
+ Hits 15729 15741 +12
- Misses 2310 2325 +15
- Partials 67 69 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1cca960
to
2e2bc5d
Compare
I'm not sure if this is part of current ticket but we also disabled sorting on requests tab. Lets enable sorting for that as well. |
I ran the code against stage environment and found this small issue. It is not necessarily caused by this PR but it is something we should discuss and fix. We are showing I also noticed that we show ![]() |
src/components/learner-credit-management/data/hooks/useBnrSubsidyRequests.js
Show resolved
Hide resolved
2e2bc5d
to
1cb524f
Compare
a173e25
to
8e38bd4
Compare
- Enable Status column filtering - Map filters to latest_action_status / latest_action_status__in - Map sorting to latest_action_status and latest_action_time
8e38bd4
to
2c054fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I run this code locally with stage data and noticed this.
Activity Tab:
- it's showing Cancelled requests as well, I don't think so we are supposed to show them here in activity tab
- Filters aren't filtering the requests, i am not sure it's because of corrupted data for pied -piper or something else. please do verify it first.

Requests Tab:
- It disrupts the requests tabs filter. It's only showing up Cancelled. Please make it correct as well.

Also, try to add necessary test cases to meet the minimum code coverage. |
For all changes
Only if submitting a visual change
Screenshot