Skip to content

Conversation

zwidekalanga
Copy link
Contributor

@zwidekalanga zwidekalanga commented Aug 11, 2025

  • Enable Status column filtering
  • Map filters to latest_action_status / latest_action_status__in
  • Map sorting to latest_action_status and latest_action_time

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

Screenshot

Screenshot 2025-09-01 at 12 43 04 PM

Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 69.64286% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.79%. Comparing base (ccbb977) to head (2c054fb).

Files with missing lines Patch % Lines
...dit-management/data/hooks/useBnrSubsidyRequests.js 68.42% 4 Missing and 2 partials ⚠️
...components/learner-credit-management/data/utils.js 37.50% 5 Missing ⚠️
...arner-credit-management/RequestStatusTableCell.jsx 75.00% 4 Missing ⚠️
...credit-management/RequestRecentActionTableCell.jsx 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
- Coverage   86.87%   86.79%   -0.08%     
==========================================
  Files         796      796              
  Lines       18106    18135      +29     
  Branches     3795     3806      +11     
==========================================
+ Hits        15729    15741      +12     
- Misses       2310     2325      +15     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zwidekalanga zwidekalanga force-pushed the feat/enable-sorting-by-action-field branch 2 times, most recently from 1cca960 to 2e2bc5d Compare August 11, 2025 08:21
@omar-sarfraz
Copy link
Member

I'm not sure if this is part of current ticket but we also disabled sorting on requests tab. Lets enable sorting for that as well.

@omar-sarfraz
Copy link
Member

I ran the code against stage environment and found this small issue. It is not necessarily caused by this PR but it is something we should discuss and fix. We are showing Waiting for learner twice in filters (see below). It is caused by this constant which we added some time ago. The issue is that for reminded and approved state we are showing Waiting for learner chip but it creates confusion when both are shown in the filters. A quick fix would be to change this constant for reminded state to something other than Waiting for learner but we should discuss it with the team to come up with a feasible approach.

I also noticed that we show cancelled state in filters, I think we should not display it because all of the requests in this table are in approved state.

image

@zwidekalanga zwidekalanga force-pushed the feat/enable-sorting-by-action-field branch from 2e2bc5d to 1cb524f Compare August 12, 2025 13:20
@zwidekalanga zwidekalanga force-pushed the feat/enable-sorting-by-action-field branch 5 times, most recently from a173e25 to 8e38bd4 Compare September 1, 2025 09:15
- Enable Status column filtering
- Map filters to latest_action_status / latest_action_status__in
- Map sorting to latest_action_status and latest_action_time
@zwidekalanga zwidekalanga force-pushed the feat/enable-sorting-by-action-field branch from 8e38bd4 to 2c054fb Compare September 1, 2025 10:30
Copy link
Contributor

@jajjibhai008 jajjibhai008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run this code locally with stage data and noticed this.
Activity Tab:

  • it's showing Cancelled requests as well, I don't think so we are supposed to show them here in activity tab
  • Filters aren't filtering the requests, i am not sure it's because of corrupted data for pied -piper or something else. please do verify it first.
Screenshot 2025-09-02 at 4 17 13 PM

Requests Tab:

  • It disrupts the requests tabs filter. It's only showing up Cancelled. Please make it correct as well.
Screenshot 2025-09-02 at 4 17 24 PM

@jajjibhai008
Copy link
Contributor

Also, try to add necessary test cases to meet the minimum code coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants