feat: Add notify all learners option for discussion post #36922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hassan-raza-1
force-pushed
the
hraza/INF-1917
branch
2 times, most recently
from
d67499f to
618c1a6
Compare
hassan-raza-1
force-pushed
the
hraza/INF-1917
branch
from
618c1a6 to
3a18235
Compare
hassan-raza-1
commented
Jun 18, 2025
| }, | ||
| 'email_template': '', | ||
| 'filters': [FILTER_AUDIT_EXPIRED_USERS_WITH_NO_ROLE], | ||
| 'waffle_flag': ENABLE_NOTIFY_ALL_LEARNERS |
There was a problem hiding this comment.
@AhtishamShahid Need your comments on adding waffle_flag attribute. As it is for temporary usage.
There was a problem hiding this comment.
visible_to setting is required here as this notification is not for all users , and waffle_flag should be removed because waffle is globally available and can be accessed from anywhere .
hassan-raza-1
requested review from
AhtishamShahid,
eemaanamir,
ayesha-waris and
muhammadadeeltajamul
hassan-raza-1
force-pushed
the
hraza/INF-1917
branch
2 times, most recently
from
8fb0222 to
5cfb268
Compare
| @@ -190,29 +190,47 @@ def test_not_authenticated(self): | |||
| """ | |||
|
|
|||
| @ddt.data( | |||
| ('new_question_post',), | |||
| ('new_discussion_post',), | |||
| # (notification_type, notify_all_learners, waffle_flag_enabled) | |||
There was a problem hiding this comment.
please remove this commented line
hassan-raza-1
force-pushed
the
hraza/INF-1917
branch
from
5cfb268 to
dfcb327
Compare
muhammadadeeltajamul
approved these changes
Jun 27, 2025
AhtishamShahid
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new notification type, new_instructor_all_learners_post, which enables course staff, course admins, discussion moderators, and discussion admins to create discussion or question posts that notify all learners. This functionality is controlled by the notifications.enable_post_notify_all_learners waffle flag, which must be enabled for the course. Web notifications are enabled by default for this notification type.
Supporting ticket
https://2u-internal.atlassian.net/browse/INF-1917
Testing instructions
Please provide detailed step-by-step instructions for testing this change.
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.