feat: container links api #36911
feat: container links api #36911
Conversation
openedx-webhooks
added
open-source-contribution
|
Thanks for the pull request, @navinkarkera! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
👍 This code is working well, thank you @navinkarkera !
I noted a bug with deleting / restoring containers with parents that can be included here, or fixed as a separate PR, as you wish.
- I tested this while testing feat: container delete confirmation modal frontend-app-authoring#2145
- I read through the code
-
I checked for accessibility issuesN/A - Includes documentation -- code comments
-
User-facing strings are extracted for translationN/A
| @@ -312,7 +312,7 @@ def filter_links( | |||
| ready_to_sync = link_filter.pop('ready_to_sync', None) | |||
| result = cls.objects.filter(**link_filter).select_related( | |||
| "upstream_container__publishable_entity__published__version", | |||
| "upstream_container__publishable_entity__learning_package" | |||
| "upstream_container__publishable_entity__learning_package", | |||
There was a problem hiding this comment.
Oops.. We should probably backport this one-line fix to Teak. Can you split it into a separate commit?
There was a problem hiding this comment.
@pomegranited Good idea.
| assert response.status_code == 200 | ||
| data = response.json() | ||
| self.assertTrue(all(o["ready_to_sync"] for o in data["results"])) | ||
| self.assertEqual(data["count"], 1) |
There was a problem hiding this comment.
(Unrelated to this line/file, but part of this issue)
When I delete a Unit from a Subsection (or a Subsection from a Section), the container API correctly returns the updated child list, but the search index still shows the old child Unit/Subsection in the container Card preview.
The content_libraries.api.containers.delete_container and restore_container methods need to send LIBRARY_CONTAINER_UPDATED for each of the affected parent containers, like we do in update_container.
There was a problem hiding this comment.
@pomegranited Fixed it here: 1d97610
navinkarkera
force-pushed
the
navin/fal-4167/container-link-api
branch
from
5d6b281 to
e9e3a86
Compare
navinkarkera
force-pushed
the
navin/fal-4167/container-link-api
branch
from
07bd28d to
1d97610
Compare
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Description
Adds list api to fetch container library links information. See openedx/frontend-app-authoring#2145 for more details.
Useful information to include:
Supporting information
Private-ref: https://tasks.opencraft.com/browse/FAL-4167Testing instructions
Please see openedx/frontend-app-authoring#2145 for instructions
Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Other information
Include anything else that will help reviewers and consumers understand the change.