-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat: deprecate get_storage_class in core/storage.py #36910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @dwong2708! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
52e93e7
to
bed450a
Compare
3033d45
to
085e01a
Compare
2607ef4
to
6197b2d
Compare
6197b2d
to
f6a4a32
Compare
f6a4a32
to
d0a3e95
Compare
Description
Fixes: #36739
The main goal is to modify the get_storage_class function referenced here in order to deprecate it.
However, a few special changes have been made, as described below:
Why does the get_storage_class function still exist with a new implementation that uses
import_string
?This change is related to the DjangoStorageReportStore class and its parent implementation. Specifically, here, a dynamic logic is used to define the storage backend.
Given the complexity of that logic, I recommend creating a separate ticket to refactor this part of the code.
Lastly, the
resolve_storage_backend
function was updated to support alegacy_sec_setting_keys
parameter. This allows it to handle storage settings defined as nested dictionaries. For example: