Skip to content

Conversation

vladislavkeblysh
Copy link
Contributor

@vladislavkeblysh vladislavkeblysh commented Jun 5, 2024

Issue

This pull request addresses the issue related to missing Open Graph (OG) image metadata in the HTML.

Context

The absence of the <meta property="og:image" /> tag was causing issues with social media sharing and previewing content. This addition ensures that the correct OG image is associated with the page for improved sharing capabilities.

Related Pull Requests

@openedx-webhooks
Copy link

openedx-webhooks commented Jun 5, 2024

Thanks for the pull request, @vladislavkeblysh!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 5, 2024
@mphilbrick211 mphilbrick211 added backport PR backports a change from main to a named release. product review PR requires product review before merging labels Jun 5, 2024
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/correct-image-for-fb-sharing-redwood.master branch from fe07a4e to c000c8b Compare August 13, 2024 13:13
@ihor-romaniuk ihor-romaniuk force-pushed the keblysh/feat/correct-image-for-fb-sharing-redwood.master branch from c000c8b to 134c039 Compare December 3, 2024 09:14
@mphilbrick211 mphilbrick211 added product review complete PR has gone through product review needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed product review PR requires product review before merging labels Dec 10, 2024
@mphilbrick211
Copy link

@brian-smith-tcril the master has been merged - do we still need this backport?

@sarina
Copy link
Contributor

sarina commented May 13, 2025

Per the conversation in related PRs, we are no longer doing Redwood releases so I'm closing this PR.

@sarina sarina closed this May 13, 2025
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Contributions May 13, 2025
@openedx-webhooks openedx-webhooks removed the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label May 13, 2025
@ihor-romaniuk ihor-romaniuk deleted the keblysh/feat/correct-image-for-fb-sharing-redwood.master branch June 11, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U product review complete PR has gone through product review
Projects
Status: Backlog
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants