feat: Removing the feature flag able to learner and admin tab#2623
Open
chethan2106 wants to merge 2 commits into
Open
feat: Removing the feature flag able to learner and admin tab#2623chethan2106 wants to merge 2 commits into
chethan2106 wants to merge 2 commits into
Conversation
rgopalrao-sonata-png
left a comment
rgopalrao-sonata-png
left a comment
Contributor
There was a problem hiding this comment.
Need to check CI
rgopalrao-sonata-png
approved these changes
May 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2623 +/- ##
==========================================
- Coverage 86.05% 86.05% -0.01%
==========================================
Files 251 251
Lines 16721 16718 -3
Branches 1658 1658
==========================================
- Hits 14390 14387 -3
Misses 1997 1997
Partials 334 334
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| def enterprise_ai_pathways_operator_enabled(): | ||
| """ | ||
| Returns whether the invite admins feature flag is enabled. |
Contributor
There was a problem hiding this comment.
nit: This comment was an erroneous copy-paste from enterprise_invite_admins_enabled, we might as well correct it now.
Suggested change
| Returns whether the invite admins feature flag is enabled. | |
| Returns whether the AI pathways operator feature flag is enabled. |
| enterprise_admin_onboarding_enabled, | ||
| enterprise_edit_highlights_enabled, | ||
| enterprise_invite_admins_enabled, | ||
| _removed_feature_placeholder, |
Contributor
There was a problem hiding this comment.
Why do we need to keep this unused argument in the tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the
enterprise_invite_admins_enabledfeature flag and enables the Learners tab and Admin tab functionality for all customers by default. The goal of this task is to:enterprise_invite_admins_enabledfeature flag.Jira:
ENT-11269
Merge checklist:
enterprise_invite_admins_enabledfeature flag.TESTING