chore: add staging ci for mayastor #1914
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Prateek Chandra <[email protected]>
Signed-off-by: Prateek Chandra <[email protected]>
Member
There was a problem hiding this comment.
With new dependencies module : #1918
We can take this from utils/dependencies instead
Member
There was a problem hiding this comment.
also we could move this to dependencies?
Member
There was a problem hiding this comment.
Wonder if the entire staging actually can move to dependencies?
CC @Abhinandan-Purkait
Contributor
Author
There was a problem hiding this comment.
I thought of doing so ..but the validate script will differ slightly in extensions as it also has to validate charts. Here and in CP there are just images (no charts)
Member
There was a problem hiding this comment.
we can make the script accept parameters for example; if not specified then it'd do images only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.