Skip to content

Conversation

@adamkorynta
Copy link
Contributor

Problem Description

Fixes #437 .

Solution

Add missing header type and add null checks for unit converter.

how you tested the change

Tested through GUI and unit test.

Where the following done:

  • Tests. Check all that apply:
    • Unit tests created or modified that run during ant test.
    • Integration tests created or modified that run during integration testing
      (Formerly called regression tests.)
    • Test procedure descriptions for manual testing
  • Was relevant documentation updated?
  • Were relevant config element (e.g. XML data) updated as appropriate

Copy link
Collaborator

@zack-rma zack-rma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good, but also appear to be causing the POST in some integration tests to fail.

@adamkorynta adamkorynta force-pushed the bugfix/config_load_decodes branch from 31fa607 to d916911 Compare April 9, 2025 17:58
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 9, 2025

@adamkorynta adamkorynta merged commit 2317342 into main Apr 9, 2025
9 checks passed
@adamkorynta adamkorynta deleted the bugfix/config_load_decodes branch April 9, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Cannot load a row in the Configs page when the Decodes Script is edited

3 participants