Skip to content

cherry-pick service-name env variable config from upstream KFP #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2025
Merged

cherry-pick service-name env variable config from upstream KFP #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions backend/src/apiserver/common/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ const (
CaBundleSecretName string = "CABUNDLE_SECRET_NAME"
RequireNamespaceForPipelines string = "REQUIRE_NAMESPACE_FOR_PIPELINES"
CompiledPipelineSpecPatch string = "COMPILED_PIPELINE_SPEC_PATCH"
MLPipelineServiceName string = "ML_PIPELINE_SERVICE_NAME"
MetadataServiceName string = "METADATA_SERVICE_NAME"
)

func IsPipelineVersionUpdatedByDefault() bool {
Expand Down Expand Up @@ -115,6 +117,14 @@ func GetPodNamespace() string {
return GetStringConfigWithDefault(PodNamespace, DefaultPodNamespace)
}

func GetMLPipelineServiceName() string {
return GetStringConfigWithDefault(MLPipelineServiceName, DefaultMLPipelineServiceName)
}

func GetMetadataServiceName() string {
return GetStringConfigWithDefault(MetadataServiceName, DefaultMetadataServiceName)
}

func GetBoolFromStringWithDefault(value string, defaultValue bool) bool {
boolVal, err := strconv.ParseBool(value)
if err != nil {
Expand Down
5 changes: 5 additions & 0 deletions backend/src/apiserver/common/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,3 +83,8 @@ const (
const (
DefaultPodNamespace string = "kubeflow"
)

const (
DefaultMLPipelineServiceName string = "ml-pipeline"
DefaultMetadataServiceName string = "metadata-grpc-service"
)
8 changes: 4 additions & 4 deletions backend/src/v2/cacheutils/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const (
MaxClientGRPCMessageSize = 100 * 1024 * 1024
// The endpoint uses Kubernetes service DNS name with namespace:
// https://kubernetes.io/docs/concepts/services-networking/service/#dns
defaultKfpApiEndpoint = "ml-pipeline.kubeflow:8887"
)

type Client interface {
Expand Down Expand Up @@ -77,7 +76,7 @@ type client struct {
var _ Client = &client{}

// NewClient creates a Client.
func NewClient(cacheDisabled bool, tlsCfg *tls.Config) (Client, error) {
func NewClient(mlPipelineServerAddress string, mlPipelineServerPort string, cacheDisabled bool, tlsCfg *tls.Config) (Client, error) {
if cacheDisabled {
return &disabledCacheClient{}, nil
}
Expand All @@ -86,9 +85,10 @@ func NewClient(cacheDisabled bool, tlsCfg *tls.Config) (Client, error) {
if tlsCfg != nil {
creds = credentials.NewTLS(tlsCfg)
}
glog.Infof("Connecting to cache endpoint %s", defaultKfpApiEndpoint)
cacheEndPoint := mlPipelineServerAddress + ":" + mlPipelineServerPort
glog.Infof("Connecting to cache endpoint %s", cacheEndPoint)
conn, err := grpc.NewClient(
defaultKfpApiEndpoint,
cacheEndPoint,
grpc.WithDefaultCallOptions(grpc.MaxCallRecvMsgSize(MaxClientGRPCMessageSize)),
grpc.WithTransportCredentials(creds),
)
Expand Down
6 changes: 3 additions & 3 deletions backend/src/v2/cacheutils/cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ func TestGenerateCacheKey(t *testing.T) {
wantErr: false,
},
}
cacheClient, err := NewClient(false, &tls.Config{})
cacheClient, err := NewClient("ml-pipeline.kubeflow", "8887", false, &tls.Config{})
require.NoError(t, err)
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
Expand Down Expand Up @@ -339,7 +339,7 @@ func TestGenerateFingerPrint(t *testing.T) {
fingerPrint: "0a4cc1f15cdfad5170e1358518f7128c5278500a670db1b9a3f3d83b93db396e",
},
}
cacheClient, err := NewClient(false, &tls.Config{})
cacheClient, err := NewClient("ml-pipeline.kubeflow", "8887", false, &tls.Config{})
require.NoError(t, err)
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
Expand Down Expand Up @@ -409,7 +409,7 @@ func TestGenerateFingerPrint_ConsidersPVCNames(t *testing.T) {
},
}

cacheClient, err := NewClient(false, &tls.Config{})
cacheClient, err := NewClient("ml-pipeline.kubeflow", "8887", false, &tls.Config{})
require.NoError(t, err)

baseFP, err := cacheClient.GenerateFingerPrint(base)
Expand Down
18 changes: 10 additions & 8 deletions backend/src/v2/client_manager/client_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,13 @@ type ClientManager struct {
}

type Options struct {
MLMDServerAddress string
MLMDServerPort string
CacheDisabled bool
CaCertPath string
MLMDTLSEnabled bool
MLPipelineServerAddress string
MLPipelineServerPort string
MLMDServerAddress string
MLMDServerPort string
CacheDisabled bool
CaCertPath string
MLMDTLSEnabled bool
}

// NewClientManager creates and Init a new instance of ClientManager.
Expand Down Expand Up @@ -76,7 +78,7 @@ func (cm *ClientManager) init(opts *Options) error {
if err != nil {
return err
}
cacheClient, err := initCacheClient(opts.CacheDisabled, tlsCfg)
cacheClient, err := initCacheClient(opts.MLPipelineServerAddress, opts.MLPipelineServerPort, opts.CacheDisabled, tlsCfg)
if err != nil {
return err
}
Expand All @@ -102,6 +104,6 @@ func initMetadataClient(address string, port string, tlsCfg *tls.Config) (metada
return metadata.NewClient(address, port, tlsCfg)
}

func initCacheClient(cacheDisabled bool, tlsCfg *tls.Config) (cacheutils.Client, error) {
return cacheutils.NewClient(cacheDisabled, tlsCfg)
func initCacheClient(mlPipelineServerAddress string, mlPipelineServerPort string, cacheDisabled bool, tlsCfg *tls.Config) (cacheutils.Client, error) {
return cacheutils.NewClient(mlPipelineServerAddress, mlPipelineServerPort, cacheDisabled, tlsCfg)
}
8 changes: 5 additions & 3 deletions backend/src/v2/cmd/driver/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,10 @@ var (
k8sExecConfigJson = flag.String("kubernetes_config", "{}", "kubernetes executor config")

// config
mlmdServerAddress = flag.String("mlmd_server_address", "", "MLMD server address")
mlmdServerPort = flag.String("mlmd_server_port", "", "MLMD server port")
mlPipelineServerAddress = flag.String("ml_pipeline_server_address", "ml-pipeline", "The name of the ML pipeline API server address.")
mlPipelineServerPort = flag.String("ml_pipeline_server_port", "8887", "The port of the ML pipeline API server.")
mlmdServerAddress = flag.String("mlmd_server_address", "", "MLMD server address")
mlmdServerPort = flag.String("mlmd_server_port", "", "MLMD server port")

// output paths
executionIDPath = flag.String("execution_id_path", "", "Exeucution ID output path")
Expand Down Expand Up @@ -190,7 +192,7 @@ func drive() (err error) {
if err != nil {
return err
}
cacheClient, err := cacheutils.NewClient(*cacheDisabledFlag, tlsCfg)
cacheClient, err := cacheutils.NewClient(*mlPipelineServerAddress, *mlPipelineServerPort, *cacheDisabledFlag, tlsCfg)
if err != nil {
return err
}
Expand Down
80 changes: 43 additions & 37 deletions backend/src/v2/cmd/launcher-v2/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,26 +28,28 @@ import (

// TODO: use https://github.com/spf13/cobra as a framework to create more complex CLI tools with subcommands.
var (
copy = flag.String("copy", "", "copy this binary to specified destination path")
pipelineName = flag.String("pipeline_name", "", "pipeline context name")
runID = flag.String("run_id", "", "pipeline run uid")
parentDagID = flag.Int64("parent_dag_id", 0, "parent DAG execution ID")
executorType = flag.String("executor_type", "container", "The type of the ExecutorSpec")
executionID = flag.Int64("execution_id", 0, "Execution ID of this task.")
executorInputJSON = flag.String("executor_input", "", "The JSON-encoded ExecutorInput.")
componentSpecJSON = flag.String("component_spec", "", "The JSON-encoded ComponentSpec.")
importerSpecJSON = flag.String("importer_spec", "", "The JSON-encoded ImporterSpec.")
taskSpecJSON = flag.String("task_spec", "", "The JSON-encoded TaskSpec.")
podName = flag.String("pod_name", "", "Kubernetes Pod name.")
podUID = flag.String("pod_uid", "", "Kubernetes Pod UID.")
mlmdServerAddress = flag.String("mlmd_server_address", "", "The MLMD gRPC server address.")
mlmdServerPort = flag.String("mlmd_server_port", "8080", "The MLMD gRPC server port.")
logLevel = flag.String("log_level", "1", "The verbosity level to log.")
publishLogs = flag.String("publish_logs", "true", "Whether to publish component logs to the object store")
cacheDisabledFlag = flag.Bool("cache_disabled", false, "Disable cache globally.")
caCertPath = flag.String("ca_cert_path", "", "The path to the CA certificate to trust on connections to the ML pipeline API server and metadata server.")
mlPipelineTLSEnabled = flag.Bool("ml_pipeline_tls_enabled", false, "Set to true if mlpipeline API server serves over TLS.")
metadataTLSEnabled = flag.Bool("metadata_tls_enabled", false, "Set to true if MLMD serves over TLS.")
copy = flag.String("copy", "", "copy this binary to specified destination path")
pipelineName = flag.String("pipeline_name", "", "pipeline context name")
runID = flag.String("run_id", "", "pipeline run uid")
parentDagID = flag.Int64("parent_dag_id", 0, "parent DAG execution ID")
executorType = flag.String("executor_type", "container", "The type of the ExecutorSpec")
executionID = flag.Int64("execution_id", 0, "Execution ID of this task.")
executorInputJSON = flag.String("executor_input", "", "The JSON-encoded ExecutorInput.")
componentSpecJSON = flag.String("component_spec", "", "The JSON-encoded ComponentSpec.")
importerSpecJSON = flag.String("importer_spec", "", "The JSON-encoded ImporterSpec.")
taskSpecJSON = flag.String("task_spec", "", "The JSON-encoded TaskSpec.")
podName = flag.String("pod_name", "", "Kubernetes Pod name.")
podUID = flag.String("pod_uid", "", "Kubernetes Pod UID.")
mlPipelineServerAddress = flag.String("ml_pipeline_server_address", "ml-pipeline.kubeflow", "The name of the ML pipeline API server address.")
mlPipelineServerPort = flag.String("ml_pipeline_server_port", "8887", "The port of the ML pipeline API server.")
mlmdServerAddress = flag.String("mlmd_server_address", "", "The MLMD gRPC server address.")
mlmdServerPort = flag.String("mlmd_server_port", "8080", "The MLMD gRPC server port.")
logLevel = flag.String("log_level", "1", "The verbosity level to log.")
publishLogs = flag.String("publish_logs", "true", "Whether to publish component logs to the object store")
cacheDisabledFlag = flag.Bool("cache_disabled", false, "Disable cache globally.")
caCertPath = flag.String("ca_cert_path", "", "The path to the CA certificate to trust on connections to the ML pipeline API server and metadata server.")
mlPipelineTLSEnabled = flag.Bool("ml_pipeline_tls_enabled", false, "Set to true if mlpipeline API server serves over TLS.")
metadataTLSEnabled = flag.Bool("metadata_tls_enabled", false, "Set to true if MLMD serves over TLS.")
)

func main() {
Expand Down Expand Up @@ -79,18 +81,20 @@ func run() error {
}

launcherV2Opts := &component.LauncherV2Options{
Namespace: namespace,
PodName: *podName,
PodUID: *podUID,
MLMDServerAddress: *mlmdServerAddress,
MLMDServerPort: *mlmdServerPort,
PipelineName: *pipelineName,
RunID: *runID,
PublishLogs: *publishLogs,
CacheDisabled: *cacheDisabledFlag,
MLPipelineTLSEnabled: *mlPipelineTLSEnabled,
MLMDTLSEnabled: *metadataTLSEnabled,
CaCertPath: *caCertPath,
Namespace: namespace,
PodName: *podName,
PodUID: *podUID,
MLPipelineServerAddress: *mlPipelineServerAddress,
MLPipelineServerPort: *mlPipelineServerPort,
MLMDServerAddress: *mlmdServerAddress,
MLMDServerPort: *mlmdServerPort,
PipelineName: *pipelineName,
RunID: *runID,
PublishLogs: *publishLogs,
CacheDisabled: *cacheDisabledFlag,
MLPipelineTLSEnabled: *mlPipelineTLSEnabled,
MLMDTLSEnabled: *metadataTLSEnabled,
CaCertPath: *caCertPath,
}

switch *executorType {
Expand All @@ -110,11 +114,13 @@ func run() error {
return nil
case "container":
clientOptions := &client_manager.Options{
MLMDServerAddress: launcherV2Opts.MLMDServerAddress,
MLMDServerPort: launcherV2Opts.MLMDServerPort,
CacheDisabled: launcherV2Opts.CacheDisabled,
MLMDTLSEnabled: launcherV2Opts.MLMDTLSEnabled,
CaCertPath: launcherV2Opts.CaCertPath,
MLPipelineServerAddress: launcherV2Opts.MLPipelineServerAddress,
MLPipelineServerPort: launcherV2Opts.MLPipelineServerPort,
MLMDServerAddress: launcherV2Opts.MLMDServerAddress,
MLMDServerPort: launcherV2Opts.MLMDServerPort,
CacheDisabled: launcherV2Opts.CacheDisabled,
MLMDTLSEnabled: launcherV2Opts.MLMDTLSEnabled,
CaCertPath: launcherV2Opts.CaCertPath,
}
clientManager, err := client_manager.NewClientManager(clientOptions)
if err != nil {
Expand Down
7 changes: 5 additions & 2 deletions backend/src/v2/compiler/argocompiler/container.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"strconv"
"strings"

"github.com/kubeflow/pipelines/backend/src/v2/config"
"github.com/kubeflow/pipelines/backend/src/v2/metadata"
"google.golang.org/protobuf/encoding/protojson"

Expand Down Expand Up @@ -207,8 +208,10 @@ func (c *workflowCompiler) addContainerDriverTemplate() string {
"--http_proxy", proxy.GetConfig().GetHttpProxy(),
"--https_proxy", proxy.GetConfig().GetHttpsProxy(),
"--no_proxy", proxy.GetConfig().GetNoProxy(),
"--mlmd_server_address", metadata.DefaultConfig().Address,
"--mlmd_server_port", metadata.DefaultConfig().Port,
"--ml_pipeline_server_address", config.GetMLPipelineServerConfig().Address,
"--ml_pipeline_server_port", config.GetMLPipelineServerConfig().Port,
"--mlmd_server_address", metadata.GetMetadataConfig().Address,
"--mlmd_server_port", metadata.GetMetadataConfig().Port,
}
if c.cacheDisabled {
args = append(args, "--cache_disabled")
Expand Down
7 changes: 5 additions & 2 deletions backend/src/v2/compiler/argocompiler/dag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"strings"

"github.com/kubeflow/pipelines/backend/src/apiserver/config/proxy"
"github.com/kubeflow/pipelines/backend/src/v2/config"
"github.com/kubeflow/pipelines/backend/src/v2/metadata"

wfapi "github.com/argoproj/argo-workflows/v3/pkg/apis/workflow/v1alpha1"
Expand Down Expand Up @@ -572,8 +573,10 @@ func (c *workflowCompiler) addDAGDriverTemplate() string {
"--http_proxy", proxy.GetConfig().GetHttpProxy(),
"--https_proxy", proxy.GetConfig().GetHttpsProxy(),
"--no_proxy", proxy.GetConfig().GetNoProxy(),
"--mlmd_server_address", metadata.DefaultConfig().Address,
"--mlmd_server_port", metadata.DefaultConfig().Port,
"--ml_pipeline_server_address", config.GetMLPipelineServerConfig().Address,
"--ml_pipeline_server_port", config.GetMLPipelineServerConfig().Port,
"--mlmd_server_address", metadata.GetMetadataConfig().Address,
"--mlmd_server_port", metadata.GetMetadataConfig().Port,
}
if c.cacheDisabled {
args = append(args, "--cache_disabled")
Expand Down
4 changes: 2 additions & 2 deletions backend/src/v2/compiler/argocompiler/importer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,8 @@ func (c *workflowCompiler) addImporterTemplate() string {
fmt.Sprintf("$(%s)", component.EnvPodName),
"--pod_uid",
fmt.Sprintf("$(%s)", component.EnvPodUID),
"--mlmd_server_address", metadata.DefaultConfig().Address,
"--mlmd_server_port", metadata.DefaultConfig().Port,
"--mlmd_server_address", metadata.GetMetadataConfig().Address,
"--mlmd_server_port", metadata.GetMetadataConfig().Port,
}
if c.cacheDisabled {
args = append(args, "--cache_disabled")
Expand Down
2 changes: 2 additions & 0 deletions backend/src/v2/component/launcher_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ type LauncherV2Options struct {
Namespace,
PodName,
PodUID,
MLPipelineServerAddress,
MLPipelineServerPort,
MLMDServerAddress,
MLMDServerPort,
PipelineName,
Expand Down
2 changes: 1 addition & 1 deletion backend/src/v2/component/launcher_v2_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ func Test_get_log_Writer(t *testing.T) {
func Test_NewLauncherV2(t *testing.T) {
var testCmdArgs = []string{"sh", "-c", "echo \"hello world\""}

disabledCacheClient, _ := cacheutils.NewClient(true, &tls.Config{})
disabledCacheClient, _ := cacheutils.NewClient("ml-pipeline.kubeflow", "8887", true, &tls.Config{})
var testLauncherV2Deps = client_manager.NewFakeClientManager(
fake.NewSimpleClientset(),
metadata.NewFakeClient(),
Expand Down
17 changes: 17 additions & 0 deletions backend/src/v2/config/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (
"strconv"
"strings"

"github.com/kubeflow/pipelines/backend/src/apiserver/common"
"github.com/kubeflow/pipelines/backend/src/v2/objectstore"
"sigs.k8s.io/yaml"

Expand All @@ -43,6 +44,10 @@ const (
minioArtifactAccessKeyKey = "accesskey"
)

const (
mlPipelineGrpcServicePort = "8887"
)

type BucketProviders struct {
Minio *MinioProviderConfig `json:"minio"`
S3 *S3ProviderConfig `json:"s3"`
Expand All @@ -58,6 +63,11 @@ type Config struct {
data map[string]string
}

type ServerConfig struct {
Address string
Port string
}

// FromConfigMap loads config from a kfp-launcher Kubernetes config map.
func FromConfigMap(ctx context.Context, clientSet kubernetes.Interface, namespace string) (*Config, error) {
config, err := clientSet.CoreV1().ConfigMaps(namespace).Get(ctx, configMapName, metav1.GetOptions{})
Expand Down Expand Up @@ -181,3 +191,10 @@ func getDefaultMinioSessionInfo() (objectstore.SessionInfo, error) {
}
return sess, nil
}

func GetMLPipelineServerConfig() *ServerConfig {
return &ServerConfig{
Address: common.GetMLPipelineServiceName() + "." + common.GetPodNamespace(),
Port: mlPipelineGrpcServicePort,
}
}
Comment on lines +195 to +200
Copy link

@coderabbitai coderabbitai bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

Incomplete Kubernetes service DNS name construction.

The constructed address common.GetMLPipelineServiceName() + "." + common.GetPodNamespace() produces an incomplete DNS name like ml-pipeline.kubeflow. The canonical Kubernetes service DNS format is <service>.<namespace>.svc.cluster.local.

Check whether this shortened format is intentional and functional in your environment, or if it should be updated to match the full DNS format used elsewhere (e.g., see how metadata server address is constructed).

🏁 Script executed:

#!/bin/bash
# Compare with metadata service address construction
rg -n "GetMetadataServiceName|metadata-grpc-service" backend/src/v2/metadata/ -A 3 -B 3
rg -n "svc\.cluster\.local" backend/src/v2/ -C 3

Length of output: 887

🌐 Web query:

Does Kubernetes service DNS resolution work with shortened service.namespace format or does it require the full service.namespace.svc.cluster.local format?

💡 Result:

Shortened names work. Inside a Pod’s namespace you can use just "service"; from other namespaces "service.namespace" also resolves (or use the full FQDN "service.namespace.svc.cluster.local"). Resolution depends on the Pod’s DNS search path and ndots behavior; Windows pods have additional limitations (they generally need the namespace suffix or full FQDN). [1][2]

Sources:
[1] Kubernetes: DNS for Services and Pods.
[2] Kubernetes service-discovery / resolv.conf explanation (search suffixes and ndots).

Update ML pipeline service address to use full Kubernetes DNS format.

The verification confirms an actual inconsistency in your codebase. The metadata service uses the full FQDN format (service.namespace.svc.cluster.local), while the ML pipeline service uses the shortened format (service.namespace).

While shortened names like "service.namespace" do resolve in Kubernetes via DNS search paths, this approach is less portable and depends on DNS configuration. Windows pods generally need the namespace suffix or full FQDN, making the full format more reliable across environments.

Update backend/src/v2/config/env.go:196 to match the metadata service pattern:

Address: common.GetMLPipelineServiceName() + "." + common.GetPodNamespace() + ".svc.cluster.local",
🤖 Prompt for AI Agents 
In backend/src/v2/config/env.go around lines 195 to 200, the ML pipeline service
Address uses the shortened DNS form (service.namespace); update it to the full
Kubernetes DNS format to match the metadata service by appending
".svc.cluster.local" (i.e., construct Address using
common.GetMLPipelineServiceName() + "." + common.GetPodNamespace() +
".svc.cluster.local"), ensuring consistency and portability across environments.

5 changes: 2 additions & 3 deletions backend/src/v2/metadata/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package metadata
import "github.com/kubeflow/pipelines/backend/src/apiserver/common"

const (
metadataGrpcServiceName = "metadata-grpc-service"
metadataGrpcServicePort = "8080"
)

Expand All @@ -12,9 +11,9 @@ type ServerConfig struct {
Port string
}

func DefaultConfig() *ServerConfig {
func GetMetadataConfig() *ServerConfig {
return &ServerConfig{
Address: metadataGrpcServiceName + "." + common.GetPodNamespace() + ".svc.cluster.local",
Address: common.GetMetadataServiceName() + "." + common.GetPodNamespace() + ".svc.cluster.local",
Port: metadataGrpcServicePort,
}
}
2 changes: 1 addition & 1 deletion backend/test/v2/integration/cache_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ func TestCache(t *testing.T) {

func (s *CacheTestSuite) SetupSuite() {
var err error
s.mlmdClient, err = testutils.NewTestMlmdClient("127.0.0.1", metadata.DefaultConfig().Port, *config.TLSEnabled, *config.CaCertPath)
s.mlmdClient, err = testutils.NewTestMlmdClient("127.0.0.1", metadata.GetMetadataConfig().Port, *config.TLSEnabled, *config.CaCertPath)
require.NoError(s.T(), err)
require.NotNil(s.T(), s.mlmdClient)
}
Expand Down
Loading
Loading