-
Notifications
You must be signed in to change notification settings - Fork 13
Merge master to stable new #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: mprahl <[email protected]>
…low#12082) * Implement TLS option for pod-to-pod communication. Signed-off-by: agoins <[email protected]> * Use Envoy ConfigMap in base metadata config. Update from utilizing config added via Dockerfile, to match TLS config formatting. Signed-off-by: agoins <[email protected]> --------- Signed-off-by: agoins <[email protected]>
kubeflow#12180) Signed-off-by: VaniHaripriya <[email protected]>
* adding myself as a reviewer Signed-off-by: Nelesh Singla <[email protected]> * fixing go linting errors Signed-off-by: Nelesh Singla <[email protected]> --------- Signed-off-by: Nelesh Singla <[email protected]>
Signed-off-by: VaniHaripriya <[email protected]>
The source distribution produced does not include all of the files needed to rebuild the wheel. This change adds a MANIFEST.in file to cause the requirements.txt and requirements-dev.txt files to be included so when the setup.py tries to read them they are present. Signed-off-by: Doug Hellmann <[email protected]>
…line resources (kubeflow#12202) * Add configuration to conditionally disable shared pipeline resources Signed-off-by: Krishan Bhasin <[email protected]> * Add configuration to conditionally disable shared pipeline resources Signed-off-by: Krishan Bhasin <[email protected]> --------- Signed-off-by: Krishan Bhasin <[email protected]>
… (kubeflow#12295) add back additionalinfo as optional make k8s error logs more generic to protect against xss remove verbose logging for minio get artifact handler sanitize rather than remove resource names + revert backend error logs fix typo + add invalid resource name tests add valid namespace check for tensorboard update pipeline upload server responses + log verbose error messages remove error wrap from backend error logs minor updates to satisfy pre commit checks update tensor board file to ensure namespace is a str update frontend code format + backend test cases update pipeline upload test cases to pass pre commit fix minor merge typo fix minor merge typo Signed-off-by: JerT33 <[email protected]>
…n Tests (kubeflow#12335) Signed-off-by: VaniHaripriya <[email protected]>
* chore: Release 2.14.3 (kubeflow#12198) Signed-off-by: mprahl <[email protected]> Signed-off-by: Humair Khan <[email protected]> * chore: release 2.14.4 (kubeflow#12299) * fix(sdk): Align the versions on kfp[kubernetes] install (kubeflow#12283) It was errantly set to install kfp-kubernetes below 2 but the versions were recently aligned. Signed-off-by: mprahl <[email protected]> (cherry picked from commit f07e276) Signed-off-by: Humair Khan <[email protected]> * chore: Release 2.14.4 Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> Co-authored-by: Matt Prahl <[email protected]> * chore: release 2.14.5 automate requirements updates Signed-off-by: Humair Khan <[email protected]> * chore(release): bump version to 2.14.5 on master branch Signed-off-by: Humair Khan <[email protected]> * cleanup release docs Signed-off-by: Humair Khan <[email protected]> * update sdk ver for loaded components Signed-off-by: Humair Khan <[email protected]> * re-compile workflow yamls to align with ver update Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: mprahl <[email protected]> Signed-off-by: Humair Khan <[email protected]> Co-authored-by: Matt Prahl <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
…kubeflow#12339) The source distribution produced does not include all of the files needed to rebuild the wheel. This change adds a MANIFEST.in file to cause the requirements.txt file to be included so when the setup.py tries to read it, it is present. Signed-off-by: Doug Hellmann <[email protected]>
Signed-off-by: kaikaila <[email protected]>
* remove pin on protobuf 6 ver Signed-off-by: Humair Khan <[email protected]> * use requirements.in for kfp-k8s and spec Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]>
) Signed-off-by: VaniHaripriya <[email protected]>
* chore: release 2.14.6 (kubeflow#12355) * chore: add publish package workflow (kubeflow#12344) Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit 08ff96b) * chore: regenerate files for ver upgrade (kubeflow#12341) Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit f689e86) * chore: update versioning policy (kubeflow#12342) Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit d0e85fa) * chore: remove pin on protobuf 6 ver (kubeflow#12345) * remove pin on protobuf 6 ver Signed-off-by: Humair Khan <[email protected]> * use requirements.in for kfp-k8s and spec Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit 06e6a44) * test for kfp-server-api codegen in ci Signed-off-by: Humair Khan <[email protected]> (cherry picked from commit b23aac8) * chore: Release 2.14.6 Signed-off-by: Humair Khan <[email protected]> * build wheels from sdist Signed-off-by: Humair Khan <[email protected]> * revert click version change Pin click on 8.1.8. Due to compatibility issues, cli tests fail on click>8.1.8 in Python >= 3.13. Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]> * revert click version change Pin click on 8.1.8. Due to compatibility issues, cli tests fail on click>8.1.8 in Python >= 3.13. Signed-off-by: Humair Khan <[email protected]> * update requirements Signed-off-by: Humair Khan <[email protected]> * update golden files due to sdk version change Signed-off-by: Humair Khan <[email protected]> --------- Signed-off-by: Humair Khan <[email protected]>
* Fix CI to pass the TLS client flags This also adds wait logic for the cert-manager secret to be provisioned. Signed-off-by: mprahl <[email protected]> * Stop passing in explicit MySQL configurations to MLMD in TLS mode This conflicts with the configuration options. Signed-off-by: mprahl <[email protected]> * Disable CI for unimplemented test scenarios Pod to Pod TLS manifests are not yet implemented for Kubernetes Native API mode Signed-off-by: mprahl <[email protected]> * Build metadata-writer in CI to avoid TLS connection errors Signed-off-by: mprahl <[email protected]> * Provide --ca_cert_path only if one is set Signed-off-by: mprahl <[email protected]> * Use a clearer path for the custom CA files Having it be under /etc/pki/tls could override the system CAs. Signed-off-by: mprahl <[email protected]> * Add missing mlPipelineServiceTLSEnabled flag on SWF TLS manifests Signed-off-by: mprahl <[email protected]> * Add TLS connection info to importer Signed-off-by: mprahl <[email protected]> --------- Signed-off-by: mprahl <[email protected]>
…beflow#12350 (kubeflow#12351) Signed-off-by: JerT33 <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
* add ml-piplines-ui-aritfact deployment Signed-off-by: Harshvir Potpose <[email protected]> * rm unused env vars Signed-off-by: Harshvir Potpose <[email protected]> * fix lifcycle policy Signed-off-by: Harshvir Potpose <[email protected]> * turn off artifact proxy Signed-off-by: Harshvir Potpose <[email protected]> * single-line ternary assignment Signed-off-by: Harshvir Potpose <[email protected]> * use descriptive variable name Signed-off-by: Harshvir Potpose <[email protected]> * Update sync.py fix variable names Signed-off-by: Julius von Kohout <[email protected]> * test artifact-proxy in ci Signed-off-by: Harshvir Potpose <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> * cleanup Signed-off-by: Harshvir Potpose <[email protected]> * add artifact proxy test Signed-off-by: Harshvir Potpose <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> * Apply suggestions from code review Signed-off-by: Julius von Kohout <[email protected]> * Update test-artifact-proxy.sh Signed-off-by: Julius von Kohout <[email protected]> * Update test-artifact-proxy.sh Signed-off-by: Julius von Kohout <[email protected]> * Update test-artifact-proxy.sh Signed-off-by: Julius von Kohout <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> * fix Signed-off-by: Harshvir Potpose <[email protected]> * fix artifact-proxy test Signed-off-by: Harshvir Potpose <[email protected]> * make it more readable Signed-off-by: Harshvir Potpose <[email protected]> * increase timeout Signed-off-by: Harshvir Potpose <[email protected]> * add debug Signed-off-by: Harshvir Potpose <[email protected]> * disable istio sidecar injection Signed-off-by: Harshvir Potpose <[email protected]> * add patch reference Signed-off-by: Harshvir Potpose <[email protected]> * remove debug statements Signed-off-by: Harshvir Potpose <[email protected]> * create profile after deployment Signed-off-by: Harshvir Potpose <[email protected]> * fix deploy script logic Signed-off-by: Harshvir Potpose <[email protected]> * move patches to kustomization.yaml Signed-off-by: Harshvir Potpose <[email protected]> * add namespace to seaweedfs service urls Signed-off-by: Harshvir Potpose <[email protected]> * Update kustomization.yaml Signed-off-by: Julius von Kohout <[email protected]> * Update .github/resources/manifests/multiuser/artifact-proxy/kustomization.yaml Co-authored-by: Matt Prahl <[email protected]> Signed-off-by: Julius von Kohout <[email protected]> * Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py Co-authored-by: Matt Prahl <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py Co-authored-by: Matt Prahl <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> * Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py Co-authored-by: Matt Prahl <[email protected]> Signed-off-by: Harshvir Potpose <[email protected]> --------- Signed-off-by: Harshvir Potpose <[email protected]> Signed-off-by: Julius von Kohout <[email protected]> Co-authored-by: Julius von Kohout <[email protected]> Co-authored-by: Matt Prahl <[email protected]>
kubeflow#12364) Signed-off-by: Nelesh Singla <[email protected]>
…2374) Add missing envvar to the deployment of the ml-pipeline-ui-artifact to set the right namespace Signed-off-by: Alvaro Alonso <[email protected]>
…files for supporting Arm64 platform (kubeflow#12313) Update backend/Dockerfile with "ARG TARGETARCH" to get docker's "--platform" parameters. it supports backend/Dockerfile to download the packages matched CPU architecture. Update backend/Dockerfile.driver and backend/Dockerfile.launcher by removing the parameter, GOARCH, Update Dockerfile.driver Update Dockerfile.launcher Signed-off-by: jtu-ampere <[email protected]>
Signed-off-by: agoins <[email protected]>
Signed-off-by: agoins <[email protected]>
Signed-off-by: agoins <[email protected]>
Use the v1 DSPA in the GitHub workflow comment
# This is the 1st commit message: Linting fixes. Signed-off-by: agoins <[email protected]>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
🚦 Integration Test Verification RequiredThis pull request is merging main → stable and requires integration test verification. ✅ Required Action:Comment 📝 Steps:
🔒 Authorization:Only organization members and owners can use the This requirement ensures production stability by verifying integration tests against the latest ODH nightly build. |
|
/integration-tests-ok |
Test Results 1 files 1 suites 10m 26s ⏱️ Results for commit 294a328. ♻️ This comment has been updated with latest results. |
Signed-off-by: Nelesh Singla <[email protected]>
|
/integration-tests-ok |
reuse existing action to build and push to quay.io
Signed-off-by: Nelesh Singla <[email protected]>
# This is the 1st commit message: Cherry-pick pod namespace env var from upstream. Signed-off-by: agoins <[email protected]> # This is the commit message #2: fix Signed-off-by: agoins <[email protected]>
ci: checking out before running action
Cherry-pick pod namespace env var from upstream.
Signed-off-by: Nelesh Singla <[email protected]>
ci: Fix docker build3
|
/integration-tests-ok |
|
/integration-tests-ok |
1 similar comment
|
/integration-tests-ok |
|
/integration-tests-ok |
1 similar comment
|
/integration-tests-ok |
Signed-off-by: Nelesh Singla <[email protected]>
ci: fixing the login logic for github cli
|
Change to PR detected. A new PR build was completed. |
Description of your changes:
Checklist: