Skip to content

Conversation

@nsingla
Copy link

@nsingla nsingla commented Nov 17, 2025

Description of your changes:

Checklist:

mprahl and others added 30 commits September 24, 2025 17:22
…low#12082)

* Implement TLS option for pod-to-pod communication.

Signed-off-by: agoins <[email protected]>

* Use Envoy ConfigMap in base metadata config.

Update from utilizing config added via Dockerfile, to match TLS config formatting.

Signed-off-by: agoins <[email protected]>

---------

Signed-off-by: agoins <[email protected]>
* adding myself as a reviewer

Signed-off-by: Nelesh Singla <[email protected]>

* fixing go linting errors

Signed-off-by: Nelesh Singla <[email protected]>

---------

Signed-off-by: Nelesh Singla <[email protected]>
The source distribution produced does not include all of the files
needed to rebuild the wheel. This change adds a MANIFEST.in file to
cause the requirements.txt and requirements-dev.txt files to be included
so when the setup.py tries to read them they are present.

Signed-off-by: Doug Hellmann <[email protected]>
…line resources (kubeflow#12202)

* Add configuration to conditionally disable shared pipeline resources

Signed-off-by: Krishan Bhasin <[email protected]>

* Add configuration to conditionally disable shared pipeline resources

Signed-off-by: Krishan Bhasin <[email protected]>

---------

Signed-off-by: Krishan Bhasin <[email protected]>
… (kubeflow#12295)

add back additionalinfo as optional



make k8s error logs more generic to protect against xss



remove verbose logging for minio get artifact handler



sanitize rather than remove resource names + revert backend error logs



fix typo + add invalid resource name tests



add valid namespace check for tensorboard



update pipeline upload server responses + log verbose error messages



remove error wrap from backend error logs



minor updates to satisfy pre commit checks



update tensor board file to ensure namespace is a str



update frontend code format + backend test cases



update pipeline upload test cases to pass pre commit



fix minor merge typo



fix minor merge typo

Signed-off-by: JerT33 <[email protected]>
* chore: Release 2.14.3 (kubeflow#12198)

Signed-off-by: mprahl <[email protected]>
Signed-off-by: Humair Khan <[email protected]>

* chore: release 2.14.4 (kubeflow#12299)

* fix(sdk): Align the versions on kfp[kubernetes] install (kubeflow#12283)

It was errantly set to install kfp-kubernetes below 2 but the versions were
recently aligned.

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit f07e276)

Signed-off-by: Humair Khan <[email protected]>

* chore: Release 2.14.4

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>

* chore: release 2.14.5

automate requirements updates

Signed-off-by: Humair Khan <[email protected]>

* chore(release): bump version to 2.14.5 on master branch

Signed-off-by: Humair Khan <[email protected]>

* cleanup release docs

Signed-off-by: Humair Khan <[email protected]>

* update sdk ver for loaded components

Signed-off-by: Humair Khan <[email protected]>

* re-compile workflow yamls to align with ver update

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: mprahl <[email protected]>
Signed-off-by: Humair Khan <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>
…kubeflow#12339)

The source distribution produced does not include all of the files needed
to rebuild the wheel. This change adds a MANIFEST.in file to cause the
requirements.txt file to be included so when the setup.py tries to read
it, it is present.

Signed-off-by: Doug Hellmann <[email protected]>
* remove pin on protobuf 6 ver

Signed-off-by: Humair Khan <[email protected]>

* use requirements.in for kfp-k8s and spec

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>
* chore: release 2.14.6 (kubeflow#12355)

* chore: add publish package workflow (kubeflow#12344)

Signed-off-by: Humair Khan <[email protected]>
(cherry picked from commit 08ff96b)

* chore: regenerate files for ver upgrade (kubeflow#12341)

Signed-off-by: Humair Khan <[email protected]>
(cherry picked from commit f689e86)

* chore: update versioning policy (kubeflow#12342)

Signed-off-by: Humair Khan <[email protected]>

(cherry picked from commit d0e85fa)

* chore: remove pin on protobuf 6 ver (kubeflow#12345)

* remove pin on protobuf 6 ver

Signed-off-by: Humair Khan <[email protected]>

* use requirements.in for kfp-k8s and spec

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>

(cherry picked from commit 06e6a44)

* test for kfp-server-api codegen in ci

Signed-off-by: Humair Khan <[email protected]>
(cherry picked from commit b23aac8)

* chore: Release 2.14.6

Signed-off-by: Humair Khan <[email protected]>

* build wheels from sdist

Signed-off-by: Humair Khan <[email protected]>

* revert click version change

Pin click on 8.1.8. Due to compatibility issues, cli tests fail on click>8.1.8 in Python >= 3.13.

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>

* revert click version change

Pin click on 8.1.8. Due to compatibility issues, cli tests fail on click>8.1.8 in Python >= 3.13.

Signed-off-by: Humair Khan <[email protected]>

* update requirements

Signed-off-by: Humair Khan <[email protected]>

* update golden files due to sdk version change

Signed-off-by: Humair Khan <[email protected]>

---------

Signed-off-by: Humair Khan <[email protected]>
* Fix CI to pass the TLS client flags

This also adds wait logic for the cert-manager secret to be provisioned.

Signed-off-by: mprahl <[email protected]>

* Stop passing in explicit MySQL configurations to MLMD in TLS mode

This conflicts with the configuration options.

Signed-off-by: mprahl <[email protected]>

* Disable CI for unimplemented test scenarios

Pod to Pod TLS manifests are not yet implemented for Kubernetes Native API mode

Signed-off-by: mprahl <[email protected]>

* Build metadata-writer in CI to avoid TLS connection errors

Signed-off-by: mprahl <[email protected]>

* Provide --ca_cert_path only if one is set

Signed-off-by: mprahl <[email protected]>

* Use a clearer path for the custom CA files

Having it be under /etc/pki/tls could override the system CAs.

Signed-off-by: mprahl <[email protected]>

* Add missing mlPipelineServiceTLSEnabled flag on SWF TLS manifests

Signed-off-by: mprahl <[email protected]>

* Add TLS connection info to importer

Signed-off-by: mprahl <[email protected]>

---------

Signed-off-by: mprahl <[email protected]>
* add ml-piplines-ui-aritfact deployment

Signed-off-by: Harshvir Potpose <[email protected]>

* rm unused env vars

Signed-off-by: Harshvir Potpose <[email protected]>

* fix lifcycle policy

Signed-off-by: Harshvir Potpose <[email protected]>

* turn off artifact proxy

Signed-off-by: Harshvir Potpose <[email protected]>

* single-line ternary assignment

Signed-off-by: Harshvir Potpose <[email protected]>

* use descriptive variable name

Signed-off-by: Harshvir Potpose <[email protected]>

* Update sync.py

fix variable names

Signed-off-by: Julius von Kohout <[email protected]>

* test artifact-proxy in ci

Signed-off-by: Harshvir Potpose <[email protected]>

* fix

Signed-off-by: Harshvir Potpose <[email protected]>

* fix

Signed-off-by: Harshvir Potpose <[email protected]>

* cleanup

Signed-off-by: Harshvir Potpose <[email protected]>

* add artifact proxy test

Signed-off-by: Harshvir Potpose <[email protected]>

* fix

Signed-off-by: Harshvir Potpose <[email protected]>

* Apply suggestions from code review

Signed-off-by: Julius von Kohout <[email protected]>

* Update test-artifact-proxy.sh

Signed-off-by: Julius von Kohout <[email protected]>

* Update test-artifact-proxy.sh

Signed-off-by: Julius von Kohout <[email protected]>

* Update test-artifact-proxy.sh

Signed-off-by: Julius von Kohout <[email protected]>

* fix

Signed-off-by: Harshvir Potpose <[email protected]>

* fix

Signed-off-by: Harshvir Potpose <[email protected]>

* fix artifact-proxy test

Signed-off-by: Harshvir Potpose <[email protected]>

* make it more readable

Signed-off-by: Harshvir Potpose <[email protected]>

* increase timeout

Signed-off-by: Harshvir Potpose <[email protected]>

* add debug

Signed-off-by: Harshvir Potpose <[email protected]>

* disable istio sidecar injection

Signed-off-by: Harshvir Potpose <[email protected]>

* add patch reference

Signed-off-by: Harshvir Potpose <[email protected]>

* remove debug statements

Signed-off-by: Harshvir Potpose <[email protected]>

* create profile after deployment

Signed-off-by: Harshvir Potpose <[email protected]>

* fix deploy script logic

Signed-off-by: Harshvir Potpose <[email protected]>

* move patches to kustomization.yaml

Signed-off-by: Harshvir Potpose <[email protected]>

* add namespace to seaweedfs service urls

Signed-off-by: Harshvir Potpose <[email protected]>

* Update kustomization.yaml

Signed-off-by: Julius von Kohout <[email protected]>

* Update .github/resources/manifests/multiuser/artifact-proxy/kustomization.yaml

Co-authored-by: Matt Prahl <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>

* Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py

Co-authored-by: Matt Prahl <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>

* Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py

Co-authored-by: Matt Prahl <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>

* Update manifests/kustomize/base/installs/multi-user/pipelines-profile-controller/sync.py

Co-authored-by: Matt Prahl <[email protected]>
Signed-off-by: Harshvir Potpose <[email protected]>

---------

Signed-off-by: Harshvir Potpose <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Co-authored-by: Julius von Kohout <[email protected]>
Co-authored-by: Matt Prahl <[email protected]>
…2374)

Add missing envvar to the deployment of the ml-pipeline-ui-artifact
to set the right namespace

Signed-off-by: Alvaro Alonso <[email protected]>
…files for supporting Arm64 platform (kubeflow#12313)

Update backend/Dockerfile with "ARG TARGETARCH" to get docker's "--platform" parameters. it supports backend/Dockerfile to download the packages matched CPU architecture.
Update backend/Dockerfile.driver and backend/Dockerfile.launcher by removing the parameter, GOARCH,



Update Dockerfile.driver



Update Dockerfile.launcher

Signed-off-by: jtu-ampere <[email protected]>
Use the v1 DSPA in the GitHub workflow comment
# This is the 1st commit message:

Linting fixes.

Signed-off-by: agoins <[email protected]>
@coderabbitai
Copy link

coderabbitai bot commented Nov 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch master

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link

openshift-ci bot commented Nov 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign humairak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link

🚦 Integration Test Verification Required

This pull request is merging mainstable and requires integration test verification.

✅ Required Action:

Comment /integration-tests-ok on this PR only after running the integration tests.

📝 Steps:

  1. Run integration tests in OpenShift cluster with latest ODH nightly
    1. Go to this Jenkins job
    2. Provide Cluster Name
    3. Check Install_Cluster checkbox
    4. Check "DEPROVISION_AFTER_INSTALL_FAILURE" if you want to destroy the cluster on job failure automatically
    5. Check "ADD_ICSP" is not checked
    6. Enter ODS_BUILD_URL=odh-nightly
    7. Enter UPDATE_CHANNEL=odh-nightlies
    8. Uncheck RUN_TESTS
    9. Enter RUN_DASHBOARD_TESTS=SmokeSet1 (this will run cypress Dashboard Tests Job as a downstream job)
    10. Run the job
    11. Once the deployment is DONE and your cluster is available, and you have updates in master after the ODH nightly build time:
      • Login to openshift console
      • Go to Operator > Installed Operators > Open Data Hub Operator > Data Science Cluster > default-dsc
      • Open the yaml spec
      • Update the aipipelines section with:
        aipipelines:
             devFlags:
                 manifests:
                   - uri: https://github.com/opendatahub-io/data-science-pipelines-operator/tarball/main
                     contextDir: config
                     sourcePath: base
             managementState: Managed
      
      • Save and wait for DSPO to update
    12. Deploy DSPA
    13. Run Iris Pipeline, Flip Coin pipelines
    14. Make sure the pipeline runs Succeeds
    15. Repeat the above steps but this time check ENABLE_FIPS_IN_CLUSTER checkbox to create a FIPS cluster
  2. Comment /integration-tests-ok on this PR to add the verification label
  3. This workflow check will automatically pass once the label is added

🔒 Authorization:

Only organization members and owners can use the /integration-tests-ok command.


This requirement ensures production stability by verifying integration tests against the latest ODH nightly build.

@nsingla
Copy link
Author

nsingla commented Nov 17, 2025

/integration-tests-ok

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

Test Results

 1 files   1 suites   10m 26s ⏱️
72 tests 33 ✅ 39 💤 0 ❌
81 runs  42 ✅ 39 💤 0 ❌

Results for commit 294a328.

♻️ This comment has been updated with latest results.

@HumairAK
Copy link

/integration-tests-ok

openshift-merge-bot bot and others added 7 commits November 17, 2025 19:00
reuse existing action to build and push to quay.io
# This is the 1st commit message:

Cherry-pick pod namespace env var from upstream.

Signed-off-by: agoins <[email protected]>

# This is the commit message #2:

fix

Signed-off-by: agoins <[email protected]>
ci: checking out before running action
Cherry-pick pod namespace env var from upstream.
Signed-off-by: Nelesh Singla <[email protected]>
@mprahl
Copy link

mprahl commented Nov 18, 2025

/integration-tests-ok

@nsingla nsingla marked this pull request as ready for review November 18, 2025 19:45
@openshift-ci openshift-ci bot requested review from gmfrasca and hbelmiro November 18, 2025 19:45
@nsingla
Copy link
Author

nsingla commented Nov 18, 2025

/integration-tests-ok

1 similar comment
@mprahl
Copy link

mprahl commented Nov 18, 2025

/integration-tests-ok

@nsingla nsingla marked this pull request as draft November 18, 2025 21:18
@HumairAK
Copy link

/integration-tests-ok

1 similar comment
@nsingla
Copy link
Author

nsingla commented Nov 19, 2025

/integration-tests-ok

nsingla and others added 2 commits November 19, 2025 15:02
@nsingla nsingla closed this Nov 19, 2025
@dsp-developers
Copy link

Change to PR detected. A new PR build was completed.
A set of new images have been built to help with testing out this PR:
API Server: quay.io/opendatahub/ds-pipelines-api-server:pr-225
DSP DRIVER: quay.io/opendatahub/ds-pipelines-driver:pr-225
DSP LAUNCHER: quay.io/opendatahub/ds-pipelines-launcher:pr-225
Persistence Agent: quay.io/opendatahub/ds-pipelines-persistenceagent:pr-225
Scheduled Workflow Manager: quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-225
MLMD Server: quay.io/opendatahub/mlmd-grpc-server:latest
MLMD Envoy Proxy: registry.redhat.io/openshift-service-mesh/proxyv2-rhel8:2.3.9-2
UI: quay.io/opendatahub/ds-pipelines-frontend:pr-225
TESTS: quay.io/opendatahub/ds-pipelines-tests:pr-225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.