Skip to content

fix: password visibility toggling and confirmPassword field state preservation#12588

Open
jamil314 wants to merge 4 commits intodevelopfrom
ocrvs-12558-b
Open

fix: password visibility toggling and confirmPassword field state preservation#12588
jamil314 wants to merge 4 commits intodevelopfrom
ocrvs-12558-b

Conversation

@jamil314
Copy link
Copy Markdown
Contributor

@jamil314 jamil314 commented May 8, 2026

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@jamil314 jamil314 marked this pull request as ready for review May 8, 2026 13:07
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@jamil314 jamil314 linked an issue May 8, 2026 that may be closed by this pull request
@jamil314 jamil314 changed the title fix: password visibility toggling and confirPassword field state preservation fix: password visibility toggling and confirmPassword field state preservation May 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

📊 commons test coverage

Statements: 75.48%
Branches:   39.88%
Functions:  56.85%
Lines:      75.05%
Updated at: Fri, 08 May 2026 13:38:16 GMT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

📊 events test coverage

Statements: 87%
Branches:   84.95%
Functions:  92.08%
Lines:      87%
Updated at: Fri, 08 May 2026 13:47:07 GMT

@ocrvs-bot
Copy link
Copy Markdown
Contributor

Your environment is deployed to https://ocrvs-12558-b.e2e-k8s.opencrvs.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Several UX and validation issues found in Change Password modal

2 participants