fix: enforce min/max validation on NUMBER fields and add maxLength support #12516
Open
sheikhlimon wants to merge 1 commit intoopencrvs:developfrom
Open
fix: enforce min/max validation on NUMBER fields and add maxLength support #12516sheikhlimon wants to merge 1 commit intoopencrvs:developfrom
sheikhlimon wants to merge 1 commit intoopencrvs:developfrom
Conversation
Author
|
quick heads up on two things I noticed while working on this:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NUMBER fields had min/max in their config but they weren't being forwarded to the HTML input or enforced by Zod validation. Country configs had to work around this with custom
isBetweenvalidators.This forwards
min,max, andmaxLengthas HTML attributes to the Number input and generates Zod.min()/.max()constraints from the field config so validation enforces the range automatically.Closes #10959
Checklist