Delete requirement for location statistics#12514
Open
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
ℹ️ Coverage metrics explained: |
📊 commons test coverage |
Zangetsu101
reviewed
May 4, 2026
Comment on lines
32
to
40
| locationType: z.enum(LOCATION_TYPES), | ||
| jurisdictionType: z | ||
| .enum([ | ||
| 'STATE', | ||
| 'DISTRICT', | ||
| 'LOCATION_LEVEL_3', | ||
| 'LOCATION_LEVEL_4', | ||
| 'LOCATION_LEVEL_5' | ||
| ]) |
Contributor
There was a problem hiding this comment.
Are these two still valid? Locations don't really have a jurisdiction anymore, rather they have an admin area as parent (or null if under country directly). And I believe locationType should just be a plain string?
📊 events test coverage |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.
Link this pull request to the GitHub issue (and optionally name the branch
ocrvs-<issue #>)Checklist