Skip to content

Delete requirement for location statistics#12514

Open
rikukissa wants to merge 1 commit intodevelopfrom
delete-statistics-requirement
Open

Delete requirement for location statistics#12514
rikukissa wants to merge 1 commit intodevelopfrom
delete-statistics-requirement

Conversation

@rikukissa
Copy link
Copy Markdown
Member

Description

Clearly describe what has been changed. Include relevant context or background.
Explain how the issue was fixed (if applicable) and the root cause.

Link this pull request to the GitHub issue (and optionally name the branch ocrvs-<issue #>)

Checklist

  • I have linked the correct Github issue under "Development"
  • I have tested the changes locally, and written appropriate tests
  • I have tested beyond the happy path (e.g. edge cases, failure paths)
  • I have updated the changelog with this change (if applicable)
  • I have updated the GitHub issue status accordingly

@rikukissa rikukissa requested a review from Zangetsu101 May 4, 2026 12:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

ℹ️ Coverage metrics explained:
Statements — Executed code statements (basic logic lines)
Branches — Tested decision paths (if/else, switch, ternaries)
Functions — Functions invoked during tests
Lines — Source lines executed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

📊 commons test coverage

Statements: 74.58%
Branches:   38.13%
Functions:  55.36%
Lines:      74.16%
Updated at: Mon, 04 May 2026 12:12:02 GMT

Comment on lines 32 to 40
locationType: z.enum(LOCATION_TYPES),
jurisdictionType: z
.enum([
'STATE',
'DISTRICT',
'LOCATION_LEVEL_3',
'LOCATION_LEVEL_4',
'LOCATION_LEVEL_5'
])
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two still valid? Locations don't really have a jurisdiction anymore, rather they have an admin area as parent (or null if under country directly). And I believe locationType should just be a plain string?

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

📊 events test coverage

Statements: 86.47%
Branches:   84.82%
Functions:  91.93%
Lines:      86.47%
Updated at: Mon, 04 May 2026 12:21:11 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants