Skip to content

[OCRVS-12245] ID reader ui updates#12430

Open
tahmidrahman-dsi wants to merge 7 commits intodevelopfrom
ocrvs-12245
Open

[OCRVS-12245] ID reader ui updates#12430
tahmidrahman-dsi wants to merge 7 commits intodevelopfrom
ocrvs-12245

Conversation

@tahmidrahman-dsi
Copy link
Copy Markdown
Contributor

@tahmidrahman-dsi tahmidrahman-dsi commented Apr 23, 2026 •
edited
Loading

Farajaland PR: opencrvs/opencrvs-farajaland#2114

Status Design Implementation
Default image image
Pending verification image image
Success image image
Failure on verification from MOSIP image image

@tahmidrahman-dsi
fix: show "Reset" button label for non-authenticated verification states
c6ed8c3 
"Revoke" is now reserved for the `authenticated` state only.
For `verified`, `failed`, and `pending`, the button and its
confirmation modal title both use "Reset".
@tahmidrahman-dsi tahmidrahman-dsi requested a review from naftis April 23, 2026 10:18
@tahmidrahman-dsi tahmidrahman-dsi self-assigned this Apr 23, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

ℹ️ Coverage metrics explained:
• Statements — Executed code statements (basic logic lines)
• Branches — Tested decision paths (if/else, switch, ternaries)
• Functions — Functions invoked during tests
• Lines — Source lines executed

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

📊 commons test coverage

Statements: 75.48%
Branches:   39.88%
Functions:  56.85%
Lines:      75.05%
Updated at: Fri, 08 May 2026 09:57:18 GMT

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 23, 2026 •
edited
Loading

📊 events test coverage

Statements: 86.9%
Branches:   85.08%
Functions:  92.08%
Lines:      86.9%
Updated at: Fri, 08 May 2026 10:06:42 GMT

@tahmidrahman-dsi tahmidrahman-dsi linked an issue Apr 23, 2026 that may be closed by this pull request
Adds the required supported states for ID Reader (Verification) #12245
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naftis naftis naftis approved these changes

Assignees

@tahmidrahman-dsi tahmidrahman-dsi

Labels

💅 Waiting For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adds the required supported states for ID Reader (Verification)

2 participants

@tahmidrahman-dsi @naftis