fix: Don't ask "Do you want to enable disk encryption?" for configured environment#307
Merged
Conversation
adskyiproger
changed the title
tumbledwyer
approved these changes
May 12, 2026
adskyiproger
added a commit
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related issue: opencrvs/opencrvs-core#12500
Applied fixes:
Order for the questions changed
The change allows to add all existing environments to the environment name choice list.
Don't ask question about disk encryption for existing environment
If environment was already setup we need to skip encryption question, otherwise there is a chance to break citizens data. Disk size question should be also skipped.
Testing
Questions order change
New environment: Storage configuration with encryption
Goal: Create new environment
developmentand configure encryption partition (size 200g)Existing environment: Storage configuration with encryption
Goal: Re-run script during environment upgrade from vX.Y.Z to vX.B.C. In more real world between v1.9.14 and v2.0.0. We need to skip Storage question to avoid end-user confusion.
New environment: Storage configuration without encryption
Existing environment: Encryption was disabled at creation time
Goal: Re-run script during environment upgrade from vX.Y.Z to vX.B.C. In more real world between v1.9.14 and v2.0.0. We need to skip Storage question to avoid end-user confusion.