oci: layer: fix extraction with a non-directory parent component #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #588 +/- ##
==========================================
+ Coverage 72.58% 73.68% +1.09%
==========================================
Files 68 69 +1
Lines 5424 5536 +112
==========================================
+ Hits 3937 4079 +142
+ Misses 1104 1072 -32
- Partials 383 385 +2
🚀 New features to boost your workflow:
|
|
This is my minimal implementation of project-stacker/umoci@84c2296 but without the checking of existing lowerdirs (which I don't think is necessary and isn't really doable until we do #574 -- so as far as I can see, project-stacker/umoci@0c6a585 is not necessary either). |
cyphar
force-pushed
the
overlayfs-opaque-convert
branch
from
2f6dcea to
a2c4f62
Compare
tych0
previously approved these changes
May 21, 2025
Signed-off-by: Aleksa Sarai <[email protected]>
If a layer contains a regular whiteout followed by entries underneath said path, the overlayfs-friendly behaviour is to convert the regular whiteout to an opaque whiteout so that the whiteout semantics are correct if the lowerdir has a non-empty directory at that path. Signed-off-by: Aleksa Sarai <[email protected]>
cyphar
force-pushed
the
overlayfs-opaque-convert
branch
from
a2c4f62 to
486a6a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This depends on #587 being merged.)
Also fixes #546
Signed-off-by: Aleksa Sarai [email protected]