Skip to content

Add minimum supported Go version to CI #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2025
Merged

Add minimum supported Go version to CI #1303

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37e9466
Add minimum supported Go version to CI
tianon Oct 24, 2025
b848a95
Add explicit `GOTOOLCHAIN=local` in CI
tianon Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:

strategy:
matrix:
go: [oldstable, stable]
# our oldest (officially) supported version and the two upstream-supported versions
go: [1.21.x, oldstable, stable]
Copy link
Member

@AkihiroSuda AkihiroSuda Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOTOOLCHAIN=local is needed to avoid accidental auto upgrading

Copy link
Member Author

@tianon tianon Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, good point, although we don't have a go.mod at all so it's a little bit moot for now, right?


steps:
- name: checkout source code
Expand Down
Loading