Correct prestart hook description in summary
#1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct `prestart` hook description in summary It looks like the previous description was copied from the wrong line. Update the `prestart (Deprecated)` hook's timing from being called "after the start operation is invoked but before the user-specified command executes" to "during the create operation, after the runtime environment is created and before pivot root or any equivalent operation." Signed-off-by: Lei Wang <[email protected]>
ssst0n3
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
utam0k
approved these changes
Jan 14, 2025
Member
utam0k
left a comment
utam0k
left a comment
There was a problem hiding this comment.
I've confirmed the behavior of prestart and this change looks fine to me.
https://github.com/opencontainers/runc/blob/610aa88ab201f289c05c2e262912d0630f46eb35/libcontainer/process_linux.go#L754-L759
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct
prestarthook description in summaryIt looks like the previous description was copied from the wrong line. Update the
prestart (Deprecated)hook's timing from being called "after the start operation is invoked but before the user-specified command executes" to "during the create operation, after the runtime environment is created and before pivot root or any equivalent operation."