fix: close conn in setupIO #4821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually close conn in setupIO in cases when 1) *net.UnixConn type assertion failed; 2) fd wasn't created. Signed-off-by: Mikhail Dmitrichenko <[email protected]>
cyphar
reviewed
Jul 28, 2025
| @@ -123,11 +123,13 @@ func setupIO(process *libcontainer.Process, container *libcontainer.Container, c | |||
| } | |||
| uc, ok := conn.(*net.UnixConn) | |||
| if !ok { | |||
| conn.Close() | |||
There was a problem hiding this comment.
This cannot fail, and to be honest the following error should be a panic imho.
|
A duplicate of #4780? |
|
Yes, duplicate. Sorry. I'm closing this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've noticed that in
utils_linux.go/setupIOconnectionconnmay not be closed in some scenarios. I'm not sure how likely these scenarios are in practice but still want to highlight it and add explicit close.Manually close conn in setupIO in cases when