util_linux: add connection close in setupIO #4780
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an error occurs while creating a file descriptor using
socket, err := uc.File(), this error is returned to the calling
runner.run function. The runner.run function also simply returns
this error, and, as a result, the connection created in the line
conn, err := net.Dial("unix", sockpath) remains open.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Tigran Sogomonian <[email protected]>
lifubang
reviewed
Jun 10, 2025
| @@ -123,11 +123,13 @@ func setupIO(process *libcontainer.Process, container *libcontainer.Container, c | |||
| } | |||
| uc, ok := conn.(*net.UnixConn) | |||
| if !ok { | |||
| conn.Close() | |||
There was a problem hiding this comment.
Thank you for your contribution.
In practice, omitting these close operations doesn't cause any harm, since runc will exit anyway if an error occurs during the setupIO call.
However, from a code style and best practices perspective, I think we should always close the socket connection once an error is encountered after the connection has been established.
Considering both aspects, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an error occurs while creating a file descriptor using socket, err := uc.File(), this error is returned to the calling runner.run function. The runner.run function also simply returns this error, and, as a result, the connection created in the line conn, err := net.Dial("unix", sockpath) remains open.
Found by Linux Verification Center (linuxtesting.org) with SVACE.