Remove redundant function (needs Go >= 1.23) #4387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Godkin <[email protected]>
Author
|
I'm guessing you follow the same support policy for Go versions as the language itself? (i.e. this minor and the previous) |
Member
Yes, so we still have to support Go 1.22 |
Author
|
@AkihiroSuda understood, I'll leave this open until 1.24 or if you want to close I'll open another when it's released. |
AkihiroSuda
changed the title
octavio12345300
approved these changes
Sep 29, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Member
|
Needs rebase |
Contributor
|
@BooleanCat this needs a rebase. Please let us know if you want to keep working on this |
Contributor
octavio12345300
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make use of Go 1.23's news
mapsandslicesiterators to replace a hand-crafted map key sorter.This relies on Go 1.23 being the minimum version - once it's updaded in
go.modI'll modify this commit to remove my change togo.mod.