Add semantic versioning to proto IDL #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* (A) proto/types/types.proto
- Addition of types module for version extension
* (M) proto/tunnel/tunnel.proto
* (M) cmd/target/proto/config/target_config.proto
- Adjust versioning to semver utilizing the new extension
* (M) compile_protos.sh
- Adjust protoc compilation, tidy up go mod and regenerate golang
stubs
- Regenerate golang stubs
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stubs
Previously, any versioning of grpctunnel proto IDL was contained within
//comments and has not been updated to reflect the actual changes to these files. Thus when there is reference to a version for implementation, there are multiple variations published with the same version number but different contents. An example of this is commit fae5f5d which modified the IDL without incrementing the version.This PR proposes consistency to how
.protoare versioned for gNMI/gNOI services following semver (https://semver.org) and the version fortunnel.protohas been updated to reflect the changes from the previous commit and this slight modification all in one.A new types definition is proposed using the next inline (for OpenConfig related projects)
FileOptionextension field number of1003In addition, previous typos of
SUBCRIBEandUNSUBCRIBEhave been corrected in bothtunnel.protoandtunnel.goStubs are regenerated, compile_protos.sh is updated to reflect these changes and go modules have been tidied