Skip to content

upgrade google storage adapter and fix storage-client polling issues #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

kmcrawford
Copy link
Member

This fixes issue #180

@kmcrawford kmcrawford changed the title upgrade google storage adapter and fix client polling issues upgrade google storage adapter and fix storage-client polling issues May 14, 2019
@codecov-io
Copy link

codecov-io commented May 14, 2019

Codecov Report

Merging #192 into master will decrease coverage by 1.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #192      +/-   ##
=========================================
- Coverage   96.59%   95.1%   -1.49%     
=========================================
  Files           9       9              
  Lines         323     327       +4     
  Branches       59      61       +2     
=========================================
- Hits          312     311       -1     
- Misses         11      16       +5
Impacted Files Coverage Δ
packages/oc-gs-storage-adapter/index.js 90.81% <100%> (-4.93%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1dc77e1...714c394. Read the comment docs.

Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @kmcrawford - I'll leave to you to merge if you're happy with it.

@kmcrawford
Copy link
Member Author

@matteofigus just noticed this was never merged.

@kmcrawford kmcrawford merged commit 3956895 into master Feb 18, 2021
@kmcrawford kmcrawford deleted the update-adapter branch February 18, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants