Skip to content
This repository was archived by the owner on Nov 26, 2025. It is now read-only.

Conversation

@michaelstingl
Copy link
Contributor

Summary

  • Add check for .Values.ingress.enabled to keycloak ingress template
  • Now respects global ingress.enabled flag like all other components
  • Fixes inconsistent behavior where keycloak would create ingress even when globally disabled

Details

Updated the keycloak ingress template from:

{{- if .Values.keycloak.internal.enabled }}

to:

{{- if and .Values.ingress.enabled .Values.keycloak.internal.enabled }}

This brings keycloak in line with all other components (opencloud, collabora, onlyoffice, collaboration) which already check both conditions.

Testing Done

# Template rendering tests:
# Test 1: No ingresses created when globally disabled
helm template test ./charts/opencloud --set ingress.enabled=false
# Result: 0 ingress resources created ✓

# Test 2: All ingresses created when enabled
helm template test ./charts/opencloud --set ingress.enabled=true
# Result: All 4 ingresses created (including keycloak) ✓

# Lint check
helm lint ./charts/opencloud
# Result: 1 chart(s) linted, 0 chart(s) failed ✓

Note: I've tested this with helm template rendering and linting, but have not done a full deployment test.
Our production setup uses ingress.enabled: true, so this change doesn't affect our current deployment.

@Tim-herbie - Could you please test this in your environment where you need to disable ingress globally? Would be great to get your feedback if this solves your use case.

Test plan for reviewers

  • Deploy with ingress.enabled: true - all ingresses should be created
  • Deploy with ingress.enabled: false - NO ingresses should be created (including keycloak)
  • Deploy with ingress.enabled: true and keycloak.internal.enabled: false - keycloak ingress should NOT be created

Fixes #103

- Add check for .Values.ingress.enabled to keycloak ingress template
- Now respects global ingress.enabled flag like all other components
- Fixes inconsistent behavior where keycloak would create ingress even when globally disabled

Fixes #103
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes inconsistent ingress creation behavior for the keycloak component by adding a check for the global ingress.enabled flag. This ensures keycloak respects the global ingress configuration like other components in the chart.

  • Adds ingress.enabled check to keycloak ingress template condition
  • Aligns keycloak behavior with other components (opencloud, collabora, onlyoffice, collaboration)
  • Prevents keycloak ingress creation when ingress is globally disabled

@Tim-herbie
Copy link
Contributor

@michaelstingl I deployed your branch, it works and fixed the ingressroute Inconsistency for keycloak. Thank you!

@michaelstingl
Copy link
Contributor Author

Thanks @Tim-herbie for testing! 🎉

Since you've confirmed it works and fixes the inconsistency, could you also formally approve the PR? Now that you have Triage permissions, your approval will help us merge this fix.

Copy link
Contributor

@Tim-herbie Tim-herbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you!

@michaelstingl michaelstingl requested a review from micbar August 1, 2025 13:32
@michaelstingl
Copy link
Contributor Author

michaelstingl commented Aug 1, 2025

Strange, I can't merge this PR? 🤔 @butonic @micbar for help plz 🙏

⚠️ Merging is blocked
At least 1 approving review is required by reviewers with write access.

@butonic butonic removed their request for review September 19, 2025 10:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent Ingress creation across subcharts (e.g. keycloak differs from others)

3 participants