This repository was archived by the owner on Nov 26, 2025. It is now read-only.
fix(keycloak): make ingress creation consistent with other components #104
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
.Values.ingress.enabledto keycloak ingress templateingress.enabledflag like all other componentsDetails
Updated the keycloak ingress template from:
{{- if .Values.keycloak.internal.enabled }}to:
{{- if and .Values.ingress.enabled .Values.keycloak.internal.enabled }}This brings keycloak in line with all other components (opencloud, collabora, onlyoffice, collaboration) which already check both conditions.
Testing Done
Note: I've tested this with helm template rendering and linting, but have not done a full deployment test.
Our production setup uses
ingress.enabled: true, so this change doesn't affect our current deployment.@Tim-herbie - Could you please test this in your environment where you need to disable ingress globally? Would be great to get your feedback if this solves your use case.
Test plan for reviewers
ingress.enabled: true- all ingresses should be createdingress.enabled: false- NO ingresses should be created (including keycloak)ingress.enabled: trueandkeycloak.internal.enabled: false- keycloak ingress should NOT be createdFixes #103