fix: 🐛 send single 'prompt' value so Entra ID OIDC works#918
Open
hoobio wants to merge 1 commit into
Open
Conversation
Microsoft Entra ID rejects authorization requests with more than one 'prompt' value (AADSTS90023). The OIDC spec allows space-separated values, and many IdPs (Keycloak, Okta) accept them, but Entra only accepts one of login/none/consent/select_account/create. The discovery-doc filter in OAuth::fetchWellKnown already narrows _supportedPromtValues against 'prompt_values_supported', but Entra does not publish that field, so the client falls back to the default 'select_account consent' and the authorize call fails. Drop 'select_account' from the default and send only 'consent'. Entra still shows an account picker on first sign-in to a tenant. Multi-account use is already covered by the desktop client's own account wizard. Fixes opencloud-eu#871 Refs owncloud/client#8562
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Microsoft Entra ID rejects the authorize call with
AADSTS90023: Unsupported 'prompt' valuebecause the desktop client sends two values (select_account consent). Entra accepts only one oflogin/none/consent/select_account/create. Other IdPs (Keycloak, Okta) are lenient and accept the space-separated form, which is why the bug hasn't surfaced sooner.The discovery-doc filter in
OAuth::fetchWellKnownalready narrows_supportedPromtValuesagainstprompt_values_supported, but Entra doesn't publish that field, so the client falls back to the default and the request fails before the browser can complete.Change
Drop
select_accountfromTheme::openIdConnectPrompt(), keepconsent. One-line change insrc/libsync/theme.cpp. Entra still shows an account picker on first sign-in to a tenant, and the desktop client's own multi-account wizard covers the "switch accounts" case.Repro (current behaviour)
Response:
AADSTS90023: Unsupported 'prompt' value.Refs
src/libsync/theme.cpp)Follow-up (not in this PR)
The hardcoded
oauthClientId()(returns"OpenCloudDesktop") only works against IdPs that accept a string client_id, or where the oCIS-side registration endpoint hands the client a dynamic registration. Entra requires a registered app with a GUID client_id, and dynamic registration isn't an option there. That's a separate, larger change (likely an oCIS-side server config field surfaced via the existing well-known/server-config fetch). Happy to scope it as a follow-up PR if there's interest.