fix(cli): align delete command wording with owner permissions#417
Open
lc0rp wants to merge 1 commit intoopenclaw:mainfrom
Open
fix(cli): align delete command wording with owner permissions#417lc0rp wants to merge 1 commit intoopenclaw:mainfrom
lc0rp wants to merge 1 commit intoopenclaw:mainfrom
Conversation
Contributor
|
@lc0rp is attempting to deploy a commit to the Amantus Machina Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clawhub delete|hide|undelete|unhidecommand descriptions to state owner/moderator/admin accessRationale
Backend soft-delete already allows owners to manage their own skills, and only requires moderator/admin for non-owners (
convex/skills.ts,setSkillSoftDeletedInternal). CLI wording was stale and implied owners were blocked.Testing
bunx vitest run packages/clawdhub/src/cli/commands/delete.test.tsbun run lintRefs #413
Greptile Summary
Updated CLI command descriptions and confirmation prompts to correctly reflect that skill owners can manage their own skills' soft-delete status without requiring moderator/admin privileges. The backend logic in
convex/skills.ts(setSkillSoftDeletedInternal) already implements this permission model: it allows owners to manage their own skills and only requires moderator/admin access for non-owners.Confidence Score: 5/5
Last reviewed commit: b2e4144