Fix two related bugs in the BuildWorkflowParameters component: #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaviththiranga
requested review from
jhivandb and
sameerajayasoma
as code owners
1. Workflow parameters merging when changing workflow types
When user changed from one workflow type to another (e.g., google-cloud-buildpacks
to docker), the review step showed merged parameters from both workflows instead
of only the currently selected workflow's parameters.
2. Form data loss when navigating back in wizard
When user navigated forward to trait steps and then back to workflow configuration,
all entered parameters were lost, forcing them to re-enter values.
kaviththiranga
force-pushed
the
fix-worklow-edit
branch
from
0ffaa2d to
2c77b43
Compare
chalindukodikara
approved these changes
Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow parameters merging when changing workflow types When user changed from one workflow type to another (e.g., google-cloud-buildpacks to docker), the review step showed merged parameters from both workflows instead of only the currently selected workflow's parameters.
Form data loss when navigating back in wizard When user navigated forward to trait steps and then back to workflow configuration, all entered parameters were lost, forcing them to re-enter values.