Skip to content

Fix trait overrides patching from backstage BE #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2025
Merged

Fix trait overrides patching from backstage BE #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions plugins/openchoreo-backend/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -627,6 +627,7 @@ export async function createRouter({
orgName,
environment,
componentTypeEnvOverrides,
traitOverrides,
} = req.body;

if (!componentName || !projectName || !orgName || !environment) {
Expand All @@ -642,6 +643,7 @@ export async function createRouter({
organizationName: orgName as string,
environment: environment as string,
componentTypeEnvOverrides: componentTypeEnvOverrides,
traitOverrides: traitOverrides,
}),
);
});
Expand Down
3 changes: 3 additions & 0 deletions plugins/openchoreo-backend/src/services/EnvironmentService/EnvironmentInfoService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,6 +1014,7 @@ export class EnvironmentInfoService implements EnvironmentService {
* @param {string} request.organizationName - Name of the organization
* @param {string} request.environment - Environment to patch binding for
* @param {any} request.componentTypeEnvOverrides - Component type environment overrides to apply
* @param {any} request.traitOverrides - Trait-specific overrides to apply
* @returns {Promise<any>} Updated binding response
*/
async patchReleaseBindingOverrides(request: {
Expand All @@ -1022,6 +1023,7 @@ export class EnvironmentInfoService implements EnvironmentService {
organizationName: string;
environment: string;
componentTypeEnvOverrides: any;
traitOverrides?: any;
}) {
const startTime = Date.now();
this.logger.debug(
Expand Down Expand Up @@ -1051,6 +1053,7 @@ export class EnvironmentInfoService implements EnvironmentService {
},
body: {
componentTypeEnvOverrides: request.componentTypeEnvOverrides,
traitOverrides: request.traitOverrides,
},
},
);
Expand Down