[FIX] Livestreaming can't be accessed #494#495
[FIX] Livestreaming can't be accessed #494#495chfsx wants to merge 4 commits intoopencast-ilias:release_10from
Conversation
chfsx
added
the
ILIAS 10
github-project-automation
Bot
moved this to Backlog
in Opencast & Opencast PageComponent
|
With the latest fixes, live-streams do now work on our installation. @ferishili: Can you please review this PR and state your findings here? Thx! |
|
Can confirm. Livestream works on our installation, too.
I guess the relative paths did the trick. 🙂 |
| )) * 60; | ||
| $accessible_from = $start - $accessible_before_start; | ||
| $accessible_to = $event->getScheduling()->getEnd()->getTimestamp(); | ||
| $accessible = ($accessible_from < time()) && ($accessible_to > time()); |
There was a problem hiding this comment.
I would suggest calling time() once and reusing it for consistency and readability:
Also use <= and >= for more precision 😄
| $accessible = ($accessible_from < time()) && ($accessible_to > time()); | |
| $now = time(); | |
| $accessible = ($accessible_from <= $now) && ($accessible_to >= $now); |
Not sure if this is overkill, but should we also handle edge cases where $accessible_from or $accessible_to might be missing or invalid?
There was a problem hiding this comment.
Thanks for the hint! I reused the code from release_9 here but it's worth to make it better of course :-) not sure about the $accessible_from or $accessible_to might be missing or invalid?
|
@ferishili see 6929cca |
|
Re-test was successful. @chfsx : PR is ready to merge! |
|
Note: @chfsx asked me to file a separate issue for this: #498 Livestream works in the most recent version, but it has cosmetic issues for me:
referring to
|
4 participants
@okaufman this PR tries to fix the issue #494, since we cannot test live events in ReviewApps, can you please deploy this in your infrastructure (ILIAS 10)? thanks a lot!