Align keyboard shortcut rewind with button 10s in Paella Player#492
Open
ferishili wants to merge 1 commit intoopencast-ilias:release_9from
Open
Align keyboard shortcut rewind with button 10s in Paella Player#492ferishili wants to merge 1 commit intoopencast-ilias:release_9from
ferishili wants to merge 1 commit intoopencast-ilias:release_9from
Conversation
github-project-automation
Bot
moved this to Backlog
in Opencast & Opencast PageComponent
Contributor
Author
|
Review App ist ready: |
|
I tried it with Firefox 149 and Chromium 147. It works. Thank you. |
|
Thanks for the fix and testing it, @ferishili and @marcusm7. @chfsx: Can you please review this PR and merge it, if everything is fine? |
chfsx
added
ILIAS 9
Contributor
|
Thanks a lot! I will release this in the next version and pick it to release_10 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #491
It only adds the default shortcut values for backward and forward rewinding, aligned with the button values.
This could be simply cherry-picked to
release_10as well.